Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 2928833002: [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid (Closed)
Patch Set: Removed timestamp from tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
index 25a41d896d1135d3dd8ae94725d6370d9641470d..c35704383b6b69b4c17b83211eb1e719bf7a7892 100644
--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
@@ -15,6 +15,7 @@
#include "platform/wtf/PtrUtil.h"
#include "platform/wtf/RefCounted.h"
#include "platform/wtf/RefPtr.h"
+#include "platform/wtf/Time.h"
#include "platform/wtf/Vector.h"
#include "platform/wtf/text/StringBuilder.h"
#include "public/platform/Platform.h"
@@ -165,6 +166,7 @@ struct RequestResponse {
: request(request), response(response) {}
String request;
String response;
+ double responseTime;
Yuta Kitamura 2017/06/09 06:26:03 We should spell this "response_time" now.
kristipark 2017/06/09 17:37:13 Done.
};
class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> {
@@ -186,6 +188,8 @@ class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> {
responses_.at(responses_.size() - num_responses_left_);
request_response.request = request.Url().GetString();
request_response.response = response.StatusText();
+ request_response.responseTime =
+ WTF::Time::FromInternalValue(response.ResponseTime()).ToDoubleT();
if (--num_responses_left_ != 0)
return;
@@ -208,6 +212,7 @@ class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> {
DataEntry::create()
.setRequest(request_response.request)
.setResponse(request_response.response)
+ .setResponseTime(request_response.responseTime)
.build();
array->addItem(std::move(entry));
}

Powered by Google App Engine
This is Rietveld 408576698