 Chromium Code Reviews
 Chromium Code Reviews Issue 2928833002:
  [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid  (Closed)
    
  
    Issue 2928833002:
  [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid  (Closed) 
  | Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp | 
| diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp | 
| index 25a41d896d1135d3dd8ae94725d6370d9641470d..4eab5d2189671eb03fb40e20be8b080d1f4d0437 100644 | 
| --- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp | 
| +++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp | 
| @@ -15,6 +15,7 @@ | 
| #include "platform/wtf/PtrUtil.h" | 
| #include "platform/wtf/RefCounted.h" | 
| #include "platform/wtf/RefPtr.h" | 
| +#include "platform/wtf/Time.h" | 
| #include "platform/wtf/Vector.h" | 
| #include "platform/wtf/text/StringBuilder.h" | 
| #include "public/platform/Platform.h" | 
| @@ -165,6 +166,7 @@ struct RequestResponse { | 
| : request(request), response(response) {} | 
| String request; | 
| String response; | 
| + int64_t responseTime; | 
| }; | 
| class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> { | 
| @@ -186,6 +188,8 @@ class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> { | 
| responses_.at(responses_.size() - num_responses_left_); | 
| request_response.request = request.Url().GetString(); | 
| request_response.response = response.StatusText(); | 
| + request_response.responseTime = | 
| + WTF::Time::FromInternalValue(response.ResponseTime()).ToTimeT(); | 
| if (--num_responses_left_ != 0) | 
| return; | 
| @@ -208,6 +212,7 @@ class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> { | 
| DataEntry::create() | 
| .setRequest(request_response.request) | 
| .setResponse(request_response.response) | 
| + .setResponseTime(request_response.responseTime) | 
| 
dgozman
2017/06/07 21:32:06
We usually send a double which means "Number of se
 
kristipark
2017/06/07 22:42:37
Done.
 | 
| .build(); | 
| array->addItem(std::move(entry)); | 
| } |