Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js

Issue 2928833002: [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
index 6cc50e925fb8cbe322b9a81885a24cb6d3978e78..02c3c300e6a3ca230a2c0df1128691cf5596344b 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
@@ -36,7 +36,8 @@ Resources.ServiceWorkerCacheView = class extends UI.SimpleView {
_createDataGrid() {
var columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'number', title: Common.UIString('#'), width: '50px'}, {id: 'request', title: Common.UIString('Request')},
- {id: 'response', title: Common.UIString('Response')}
+ {id: 'response', title: Common.UIString('Response')},
+ {id: 'responseTime', title: Common.UIString('Time Received')}
dgozman 2017/06/07 21:32:06 Should this be 'Time Cached' ?
kristipark 2017/06/07 22:42:37 Done.
]);
var dataGrid = new DataGrid.DataGrid(
columns, undefined, this._deleteButtonClicked.bind(this), this._updateData.bind(this, true));
@@ -110,6 +111,7 @@ Resources.ServiceWorkerCacheView = class extends UI.SimpleView {
data['number'] = i + skipCount;
data['request'] = entries[i].request;
data['response'] = entries[i].response;
+ data['responseTime'] = entries[i].responseTime;
var node = new DataGrid.DataGridNode(data);
node.selectable = true;
this._dataGrid.rootNode().appendChild(node);

Powered by Google App Engine
This is Rietveld 408576698