Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2928823003: Make it possible to build without enable_supervised_users.

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make it possible to build without enable_supervised_users. At least, on Linux. BUG=730773

Patch Set 1 #

Patch Set 2 : Does it still compile with the feature enabled? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -48 lines) Patch
M chrome/browser/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 5 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_prefs.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/supervised_user_whitelist_installer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_sync_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc View 3 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_attributes_storage_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_creation_policy_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/supervised_user_signin_manager_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 6 chunks +24 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/supervised_user_internals_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-08 01:40:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928823003/1
3 years, 6 months ago (2017-06-08 01:40:55 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-08 01:41:51 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928823003/20001
3 years, 6 months ago (2017-06-08 01:42:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-08 01:50:11 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 01:50:12 UTC) #6 
Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

Powered by Google App Engine
This is Rietveld 408576698