Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2928793003: Re-target wheel events only when a new scroll sequence has started. (Closed)
Patch Set: Landed migration of wheel handling to MouseWheelEventManager separately. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/renderer_host/render_widget_host_input_event_router.cc ('K') | « third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html ('k') | third_party/WebKit/Source/core/input/MouseWheelEventManager.h » ('j') | third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index d55bf538ba0a0e22f840899a56e0c9e5930121d8..18061e8a5a7d559b11f1caaad724507703aba975 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -238,6 +238,7 @@ void EventHandler::Clear() {
scroll_manager_->Clear();
gesture_manager_->Clear();
mouse_event_manager_->Clear();
+ mouse_wheel_event_manager_->Clear();
last_deferred_tap_element_ = nullptr;
event_handler_will_reset_capturing_mouse_events_node_ = false;
}
@@ -949,6 +950,7 @@ WebInputEventResult EventHandler::HandleMouseReleaseEvent(
? EventHandlingUtil::SubframeForTargetNode(
capturing_mouse_events_node_.Get())
: EventHandlingUtil::SubframeForHitTestResult(mev);
+
bokan 2017/06/15 15:47:17 Nit: remove newline
sahel 2017/06/16 14:56:20 Done.
if (event_handler_will_reset_capturing_mouse_events_node_)
capturing_mouse_events_node_ = nullptr;
if (subframe)
« content/browser/renderer_host/render_widget_host_input_event_router.cc ('K') | « third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html ('k') | third_party/WebKit/Source/core/input/MouseWheelEventManager.h » ('j') | third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698