third_party/WebKit/Source/core/input/EventHandler.h - Issue 2928793003: Re-target wheel events only when a new scroll sequence has started.

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 2928793003: Re-target wheel events only when a new scroll sequence has started. (Closed)

Patch Set: browser test updated. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/renderer_host/render_widget_host_input_event_router.cc ('K') | « third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 348 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
359	359

360 Member<Node> capturing_mouse_events_node_;	360 Member<Node> capturing_mouse_events_node_;

361 bool event_handler_will_reset_capturing_mouse_events_node_;	361 bool event_handler_will_reset_capturing_mouse_events_node_;

362	362

363 Member<LocalFrame> last_mouse_move_event_subframe_;	363 Member<LocalFrame> last_mouse_move_event_subframe_;

364 Member<Scrollbar> last_scrollbar_under_mouse_;	364 Member<Scrollbar> last_scrollbar_under_mouse_;

365	365

366 Member<Node> drag_target_;	366 Member<Node> drag_target_;

367 bool should_only_fire_drag_over_event_;	367 bool should_only_fire_drag_over_event_;

368	368

	369 Member<Node> wheel_target_;
	tdresser 2017/06/09 18:13:11 Should we move wheel logic out to a separate Wheel Should we move wheel logic out to a separate WheelEventManager, like we did for touch? There's a fair bit of wheel specific logic here. sahel 2017/06/13 15:43:20 Done. Show quoted text On 2017/06/09 18:13:11, tdresser wrote: > Should we move wheel logic out to a separate WheelEventManager, like we did for > touch? > > There's a fair bit of wheel specific logic here. Done.
	370

369 Member<HTMLFrameSetElement> frame_set_being_resized_;	371 Member<HTMLFrameSetElement> frame_set_being_resized_;

370	372

371 RefPtr<UserGestureToken> last_mouse_down_user_gesture_token_;	373 RefPtr<UserGestureToken> last_mouse_down_user_gesture_token_;

372	374

373 Member<ScrollManager> scroll_manager_;	375 Member<ScrollManager> scroll_manager_;

374 Member<MouseEventManager> mouse_event_manager_;	376 Member<MouseEventManager> mouse_event_manager_;

375 Member<KeyboardEventManager> keyboard_event_manager_;	377 Member<KeyboardEventManager> keyboard_event_manager_;

376 Member<PointerEventManager> pointer_event_manager_;	378 Member<PointerEventManager> pointer_event_manager_;

377 Member<GestureManager> gesture_manager_;	379 Member<GestureManager> gesture_manager_;

378	380

379 double max_mouse_moved_duration_;	381 double max_mouse_moved_duration_;

380	382

381 bool long_tap_should_invoke_context_menu_;	383 bool long_tap_should_invoke_context_menu_;

382	384

383 TaskRunnerTimer<EventHandler> active_interval_timer_;	385 TaskRunnerTimer<EventHandler> active_interval_timer_;

384 double last_show_press_timestamp_;	386 double last_show_press_timestamp_;

385 Member<Element> last_deferred_tap_element_;	387 Member<Element> last_deferred_tap_element_;

386	388

387 // Set on GestureTapDown if the \|pointerdown\| event corresponding to the	389 // Set on GestureTapDown if the \|pointerdown\| event corresponding to the

388 // triggering \|touchstart\| event was canceled. This suppresses mouse event	390 // triggering \|touchstart\| event was canceled. This suppresses mouse event

389 // firing for the current gesture sequence (i.e. until next GestureTapDown).	391 // firing for the current gesture sequence (i.e. until next GestureTapDown).

390 bool suppress_mouse_events_from_gestures_;	392 bool suppress_mouse_events_from_gestures_;

391 };	393 };

392	394

393 } // namespace blink	395 } // namespace blink

394	396

395 #endif // EventHandler_h	397 #endif // EventHandler_h

OLD	NEW