Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2928793003: Re-target wheel events only when a new scroll sequence has started. (Closed)
Patch Set: review comments addressed. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 last_scrollbar_under_mouse_ = nullptr; 231 last_scrollbar_under_mouse_ = nullptr;
232 frame_set_being_resized_ = nullptr; 232 frame_set_being_resized_ = nullptr;
233 drag_target_ = nullptr; 233 drag_target_ = nullptr;
234 should_only_fire_drag_over_event_ = false; 234 should_only_fire_drag_over_event_ = false;
235 last_mouse_down_user_gesture_token_.Clear(); 235 last_mouse_down_user_gesture_token_.Clear();
236 capturing_mouse_events_node_ = nullptr; 236 capturing_mouse_events_node_ = nullptr;
237 pointer_event_manager_->Clear(); 237 pointer_event_manager_->Clear();
238 scroll_manager_->Clear(); 238 scroll_manager_->Clear();
239 gesture_manager_->Clear(); 239 gesture_manager_->Clear();
240 mouse_event_manager_->Clear(); 240 mouse_event_manager_->Clear();
241 mouse_wheel_event_manager_->Clear();
241 last_deferred_tap_element_ = nullptr; 242 last_deferred_tap_element_ = nullptr;
242 event_handler_will_reset_capturing_mouse_events_node_ = false; 243 event_handler_will_reset_capturing_mouse_events_node_ = false;
243 } 244 }
244 245
245 void EventHandler::UpdateSelectionForMouseDrag() { 246 void EventHandler::UpdateSelectionForMouseDrag() {
246 mouse_event_manager_->UpdateSelectionForMouseDrag(); 247 mouse_event_manager_->UpdateSelectionForMouseDrag();
247 } 248 }
248 249
249 void EventHandler::StartMiddleClickAutoscroll(LayoutObject* layout_object) { 250 void EventHandler::StartMiddleClickAutoscroll(LayoutObject* layout_object) {
250 DCHECK(RuntimeEnabledFeatures::MiddleClickAutoscrollEnabled()); 251 DCHECK(RuntimeEnabledFeatures::MiddleClickAutoscrollEnabled());
(...skipping 1820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 MouseEventWithHitTestResults& mev, 2072 MouseEventWithHitTestResults& mev,
2072 LocalFrame* subframe) { 2073 LocalFrame* subframe) {
2073 WebInputEventResult result = 2074 WebInputEventResult result =
2074 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event()); 2075 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
2075 if (result != WebInputEventResult::kNotHandled) 2076 if (result != WebInputEventResult::kNotHandled)
2076 return result; 2077 return result;
2077 return WebInputEventResult::kHandledSystem; 2078 return WebInputEventResult::kHandledSystem;
2078 } 2079 }
2079 2080
2080 } // namespace blink 2081 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698