Issue 2928773003: more fixes for fasta analyzer integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2928773003: more fixes for fasta analyzer integration (Closed)

Created:
3 years, 6 months ago by danrubel

Modified:
3 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

more fixes for fasta analyzer integration * fix scanner adapter setSourceStart * fix fasta token copy() methods * replace "is TokenWithComment" with "?.preceedingComments != null" * update scanner test R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/56402976cd9538e0f9ff5dc250439bbb0973594b

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	pkg/analyzer/lib/src/dart/scanner/scanner.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/scanner_test.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/utilities_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/token.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

danrubel

3 years, 6 months ago (2017-06-08 22:02:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
56402976cd9538e0f9ff5dc250439bbb0973594b (presubmit successful).