ios/clean/chrome/browser/ui/commands/java_script_dialog_commands.h - Issue 2928723002: [iOS Clean] Added JavaScript dialog support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/java_script_dialog_commands.h

Issue 2928723002: [iOS Clean] Added JavaScript dialog support.

Patch Set: rebased, subclassed DialogMediator Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/commands/BUILD.gn ('k') | ios/clean/chrome/browser/ui/dialogs/BUILD.gn » ('j') | ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/web_java_script_dialog_presenter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_JAVA_SCRIPT_DIALOG_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_JAVA_SCRIPT_DIALOG_COMMANDS_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 // Commands used to manage the dismissal of JavaScript dialogs.

	11 @protocol JavaScriptDialogDismissalCommands<NSObject>

	12 // Called when a JavaScript alert dialog is dismissed by tapping the OK button.

	13 - (void)dismissJavaScriptAlert;

	14 // Called when a JavaScript confirmation dialog is dismissed. \|success\| is YES

	15 // if the user selected the OK button, and NO otherwise.

	16 - (void)dimsissJavaScriptConfirmationWithSuccess:(BOOL)success;

	17 // Called when a JavaScript prompt dialog is dismissed. \|result\| is the user's

	18 // input in the prompt.
	marq (ping after 24h) 2017/06/14 11:28:39 Should the API distinguish between the user enteri Should the API distinguish between the user entering nothing in the prompt and selecting "OK", or selecting "Cancel"? Document that \|result\| is always nil if the user selected "Cancel". kkhorimoto 2017/06/23 06:34:03 Added documentation to JavaScriptDialogRequest's \| Show quoted text On 2017/06/14 11:28:39, marq (ping after 24h) wrote: > Should the API distinguish between the user entering nothing in the prompt and > selecting "OK", or selecting "Cancel"? > > Document that \|result\| is always nil if the user selected "Cancel". Added documentation to JavaScriptDialogRequest's \|-finishRequestWithSuccess:userInput:\|.
	19 - (void)dismissJavaScriptPromptWithResult:(NSString*)result;

	20 @end

	21

	22 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_JAVA_SCRIPT_DIALOG_COMMANDS_H_

OLD	NEW