Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2928703007: Catch exceptions in ByteStreamServerChannel._outputLine() and close the channel. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Catch exceptions in ByteStreamServerChannel._outputLine() and close the channel. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/756cca3222cd77c8ff177dd8a857baba960c1dd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-08 19:18:52 UTC) #1
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-06-08 19:31:32 UTC) #2
scheglov
3 years, 6 months ago (2017-06-08 19:33:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
756cca3222cd77c8ff177dd8a857baba960c1dd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698