Issue 2928663002: gen_snapshot:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2928663002: gen_snapshot: (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

gen_snapshot: - Don't try to mmap an empty file. - Use correct filename for mapping errors. - Don't set the root library for core-jit snapshots. - Accept hyphen variants of options for entry points and compilation traces. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/22b72a845c426c7871029028ee54f003853a4a31

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -16 lines)			Patch
M	runtime/bin/file_android.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1	6 chunks	+29 lines, -16 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 6 months ago (2017-06-06 21:31:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
22b72a845c426c7871029028ee54f003853a4a31 (presubmit successful).