Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/cronet/ios/test/cronet_pkp_test.mm

Issue 2928653002: [Cronet-iOS] Public-Key-Pinning Tests (Closed)
Patch Set: Build fix on bot Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/test/cronet_pkp_test.mm
diff --git a/components/cronet/ios/test/cronet_pkp_test.mm b/components/cronet/ios/test/cronet_pkp_test.mm
new file mode 100644
index 0000000000000000000000000000000000000000..43bbeed51de7846a06e48a6366e437d4cd1990a8
--- /dev/null
+++ b/components/cronet/ios/test/cronet_pkp_test.mm
@@ -0,0 +1,204 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Cronet/Cronet.h>
+
+#include "components/cronet/ios/test/start_cronet.h"
+#include "components/grpc_support/test/quic_test_server.h"
+#include "cronet_test_base.h"
+#include "net/base/mac/url_conversions.h"
+#include "net/cert/mock_cert_verifier.h"
+#include "net/test/cert_test_util.h"
+#include "net/test/test_data_directory.h"
+
+#include "testing/gtest_mac.h"
+
+namespace cronet {
+
+static const bool kINCLUDE_SUBDOMAINS = true;
+static const bool kEXCLUDE_SUBDOMAINS = false;
+static const std::string kSERVER_CERT = "quic_test.example.com.crt";
+static NSDate* distant_future = [NSDate distantFuture];
+
+// Tests public-key-pinning functionality.
+class PkpTest : public CronetTestBase {
+ protected:
+ void SetUp() override {
+ CronetTestBase::SetUp();
+
+ NSString* full_url_str = [NSString
+ stringWithFormat:@"%@:%i",
+ [NSString
+ stringWithCString:grpc_support::kTestServerUrl
+ encoding:NSUTF8StringEncoding],
+ grpc_support::GetQuicTestServerPort()];
+ request_url_ = [NSURL URLWithString:full_url_str];
+ server_host_ = request_url_.host;
+ NSArray<NSString*>* components = [server_host_
+ componentsSeparatedByCharactersInSet:
+ [NSCharacterSet characterSetWithCharactersInString:@"."]];
+ domain_ =
+ [NSString stringWithFormat:@"%@.%@", components[components.count - 2],
+ components[components.count - 1]];
+
+ // Create a Cronet enabled NSURLSession
+ NSURLSessionConfiguration* sessionConfig =
+ [NSURLSessionConfiguration defaultSessionConfiguration];
+ [Cronet installIntoSessionConfiguration:sessionConfig];
+ url_session_ = [NSURLSession sessionWithConfiguration:sessionConfig
+ delegate:delegate_
+ delegateQueue:nil];
+
+ // Set mock cert verifier
+ [Cronet setMockCertVerifier:CreateMockCertVerifier({kSERVER_CERT}, YES)];
+ }
+
+ void TearDown() override {
+ [Cronet shutdownForTesting];
+ CronetTestBase::TearDown();
+ }
+
+ // Sends a request to a given URL, waits for the response and asserts that
+ // the response doesn't contain an error.
+ void sendRequestAndAssertSuccess(NSURL* url) {
+ sendRequestAndAssertResult(url, true);
+ }
+
+ // Sends a request to a given URL, waits for the response and asserts that
+ // the response contains an error.
+ void sendRequestAndAssertError(NSURL* url) {
+ sendRequestAndAssertResult(url, false);
+ }
+
+ // Sends a request to a given URL, waits for the response and asserts that
+ // the response is either successful or containing an error depending on
+ // the value of the passed |expected_success| parameter.
+ void sendRequestAndAssertResult(NSURL* url, bool expected_success) {
+ NSURLSessionDataTask* dataTask =
+ [url_session_ dataTaskWithURL:request_url_];
+ StartDataTaskAndWaitForCompletion(dataTask);
+ if (expected_success) {
+ ASSERT_TRUE(IsResponseSuccessful());
+ } else {
+ ASSERT_FALSE(IsResponseSuccessful());
+ }
+ }
+
+ // Adds a give public-key-pin and starts a Cronet engine for testing.
+ static void AddPkpAndStartCronet(NSString* host,
+ NSData* hash,
+ BOOL include_subdomains,
+ const NSDate* expiration_date) {
+ NSSet* hashes = [NSSet setWithObject:hash];
+ [Cronet addPublicKeyPinsForHost:host
+ pinHashes:hashes
+ includeSubdomains:include_subdomains
+ expirationDate:(NSDate*)expiration_date];
+ StartCronet(grpc_support::GetQuicTestServerPort());
+ }
+
+ // Returns an arbitrary public key hash that doesn't match with any test
+ // certificate.
+ static NSData* NonMatchingHash() {
+ const int length = 32;
+ u_char hash[length];
+ memset(hash, 77, length);
+ return [NSData dataWithBytes:hash length:length];
+ }
+
+ NSURLSession* url_session_;
+ NSURL* request_url_; // "https://test.example.com/hello.txt:62922"
+ NSString* server_host_; // test.example.com
+ NSString* domain_; // example.com
+
+}; // class PkpTest
+
+// Tests the case when a mismatching pin is set for some host that is
+// different from the one the client wants to access. In that case the other
+// host pinning policy should not be applied and the client is expected to
+// receive the successful response with the response code 200.
+TEST_F(PkpTest, TestSuccessIfPinSetForDifferentHost) {
+ AddPkpAndStartCronet(@"some-other-host.com", NonMatchingHash(),
+ kEXCLUDE_SUBDOMAINS, distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertSuccess(request_url_));
+}
+
+// Tests the case when the pin hash does not match. The client is expected to
+// receive the error response.
+TEST_F(PkpTest, TestErrorIfPinDoesNotMatch) {
+ AddPkpAndStartCronet(server_host_, NonMatchingHash(), kEXCLUDE_SUBDOMAINS,
+ distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertError(request_url_));
+}
+
+// Tests the case when the pin hash matches. The client is expected to
+// receive the successful response with the response code 200.
+TEST_F(PkpTest, TestSuccessIfPinMatches) {
+ // Calculate hash of the server certificate
+ scoped_refptr<net::X509Certificate> cert =
+ net::ImportCertFromFile(net::GetTestCertsDirectory(), kSERVER_CERT);
+ net::HashValue hash_value;
+ CalculatePublicKeySha256(*cert, &hash_value);
+ ASSERT_EQ(32ul, hash_value.size());
+ NSData* matching_hash =
+ [NSData dataWithBytes:hash_value.data() length:hash_value.size()];
+
+ AddPkpAndStartCronet(server_host_, matching_hash, kEXCLUDE_SUBDOMAINS,
+ distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertSuccess(request_url_));
+}
+
+// Tests the case when the pin hash does not match and the client accesses the
+// subdomain of the configured PKP host with includeSubdomains flag set to true.
+// The client is expected to receive the error response.
+TEST_F(PkpTest, TestIncludeSubdomainsFlagEqualTrue) {
+ AddPkpAndStartCronet(domain_, NonMatchingHash(), kINCLUDE_SUBDOMAINS,
+ distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertError(request_url_));
+}
+
+// Tests the case when the pin hash does not match and the client accesses the
+// subdomain of the configured PKP host with includeSubdomains flag set to
+// false. The client is expected to receive the successful response with the
+// response code 200.
+TEST_F(PkpTest, TestIncludeSubdomainsFlagEqualFalse) {
+ AddPkpAndStartCronet(domain_, NonMatchingHash(), kEXCLUDE_SUBDOMAINS,
+ distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertSuccess(request_url_));
+}
+
+// Tests a mismatching pin that will expire in 10 seconds. The pins should be
+// still valid and enforced during the request; thus returning the pin match
+// error.
+TEST_F(PkpTest, TestSoonExpiringPin) {
+ AddPkpAndStartCronet(server_host_, NonMatchingHash(), kEXCLUDE_SUBDOMAINS,
+ [NSDate dateWithTimeIntervalSinceNow:10]);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertError(request_url_));
+}
+
+// Tests mismatching pin that expired 1 second ago. Since the pin has
+// expired, it should not be enforced during the request; thus a successful
+// response is expected.
+TEST_F(PkpTest, TestRecentlyExpiredPin) {
+ AddPkpAndStartCronet(server_host_, NonMatchingHash(), kEXCLUDE_SUBDOMAINS,
+ [NSDate dateWithTimeIntervalSinceNow:-1]);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertSuccess(request_url_));
+}
+
+// Tests that host pinning is not persisted between multiple CronetEngine
+// instances.
+TEST_F(PkpTest, TestPinsAreNotPersisted) {
+ //
+ AddPkpAndStartCronet(server_host_, NonMatchingHash(), kEXCLUDE_SUBDOMAINS,
+ distant_future);
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertError(request_url_));
+ [Cronet shutdownForTesting];
+
+ // Restart Cronet engine and try the same request again. Since the pins are
+ // not persisted, a successful response is expected.
+ StartCronet(grpc_support::GetQuicTestServerPort());
+ ASSERT_NO_FATAL_FAILURE(sendRequestAndAssertSuccess(request_url_));
+}
+
+} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698