Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2928483005: Add an incremental reloader example and a utility tool to trigger a reload by (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
diff --git a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
index c6653299d58d6ea1695e71f29c5db6bf45f7d9c4..b3b300254d1aa71ced5afb9cedf3786b9ac5cdfa 100644
--- a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
+++ b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
@@ -23,11 +23,6 @@ import 'package:kernel/kernel.dart' hide Source;
import 'package:kernel/target/targets.dart' show TargetFlags;
import 'package:kernel/target/vm_fasta.dart' show VmFastaTarget;
-dynamic unimplemented() {
- // TODO(paulberry): get rid of this.
- throw new UnimplementedError();
-}
-
class ByteSink implements Sink<List<int>> {
final BytesBuilder builder = new BytesBuilder();
@@ -130,6 +125,8 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
}
}
+ if (watch != null) _fsState.trackedFiles.forEach((f) => watch(f, true));
+
// TODO(scheglov) Add libraries which import changed libraries.
// For now the corresponding test works because we use full library
// contents to compute signatures (not just API parts). So, every library
@@ -145,7 +142,9 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
}
@override
- void invalidateAll() => unimplemented();
+ void invalidateAll() {
+ _invalidatedFiles.addAll(_fsState.trackedFiles);
scheglov 2017/06/07 01:04:42 Please add a test.
Siggi Cherem (dart-lang) 2017/06/07 20:17:11 Done.
+ }
/// Ensure that [dillTarget] includes the [cycle] libraries. It already
/// contains all the libraries that sorted before the given [cycle] in

Powered by Google App Engine
This is Rietveld 408576698