Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: pkg/dev_compiler/lib/src/compiler/compiler.dart

Issue 2928483002: fix #27255, remove angular whitelist hack (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index 25050935e44561463f251bedc8edc80cae7d4e24..ac1d60a6e66eee332fbae639b6ecacefb57459bf 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -279,10 +279,6 @@ class CompilerOptions {
/// Hoist types in type tests
final bool hoistTypeTests;
- // TODO(kevmoo): Remove once https://github.com/dart-lang/sdk/issues/27255
- // is fixed.
- final bool useAngular2Whitelist;
-
/// Enable ES6 destructuring of named parameters. Off by default.
///
/// Older V8 versions do not accept default values with destructuring in
@@ -322,7 +318,6 @@ class CompilerOptions {
this.hoistSignatureTypes: false,
this.nameTypeTests: true,
this.hoistTypeTests: true,
- this.useAngular2Whitelist: false,
this.bazelMapping: const {},
this.summaryOutPath});
@@ -341,7 +336,6 @@ class CompilerOptions {
hoistSignatureTypes = args['hoist-signature-types'],
nameTypeTests = args['name-type-tests'],
hoistTypeTests = args['hoist-type-tests'],
- useAngular2Whitelist = args['unsafe-angular2-whitelist'],
bazelMapping = _parseBazelMappings(args['bazel-mapping']),
summaryOutPath = args['summary-out'];
@@ -390,9 +384,6 @@ class CompilerOptions {
help: 'Name types used in type tests', defaultsTo: true, hide: hide)
..addFlag('hoist-type-tests',
help: 'Hoist types used in type tests', defaultsTo: true, hide: hide)
- // TODO(kevmoo): Remove once https://github.com/dart-lang/sdk/issues/27255
- // is fixed.
- ..addFlag('unsafe-angular2-whitelist', defaultsTo: false, hide: hide)
..addOption('bazel-mapping',
help:
'--bazel-mapping=genfiles/to/library.dart,to/library.dart uses \n'
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698