Add FileState.hasMixin/hasMixinLibrary properties.

Add FileState.hasMixin/hasMixinLibrary properties.

We will use them to decide which kind of key to use for cache.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/16833bce7cdf5086c83364016d01896f53ea6775

[ahe, 2017-06-12 19:22:03]

lgtm

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:90: bool get hasMixin =>
_hasMixin;
Rename to hasMixinApplication? I think it's important to keep that distinction.

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:93: bool get hasMixinLibrary {
hasMixinApplicationLibrary?

But how about this: rename the above method to "hasMixinApplicationInPart" and
this to "hasMixinApplication".

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/test/src/incr...
File pkg/front_end/test/src/incremental/file_state_test.dart (right):

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/test/src/incr...
pkg/front_end/test/src/incremental/file_state_test.dart:368: class B extends
Object with A {}
Consider adding a test for a named mixin application as well:

class Named = Object with Mixin {}

[scheglov, 2017-06-12 19:43:19]

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:90: bool get hasMixin =>
_hasMixin;
On 2017/06/12 19:22:03, ahe wrote:
> Rename to hasMixinApplication? I think it's important to keep that
distinction.

Yeah, I actually named it initially this way.
But it felt too long.

You're right, hasMixinApplication is more precise.
Done.

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/test/src/incr...
File pkg/front_end/test/src/incremental/file_state_test.dart (right):

https://codereview.chromium.org/2928393004/diff/1/pkg/front_end/test/src/incr...
pkg/front_end/test/src/incremental/file_state_test.dart:368: class B extends
Object with A {}
On 2017/06/12 19:22:03, ahe wrote:
> Consider adding a test for a named mixin application as well:
> 
> class Named = Object with Mixin {}

Done.

[scheglov, 2017-06-12 19:43:37]

Description was changed from

==========
Add FileState.hasMixin/hasMixinLibrary properties.

We will use them to decide which kind of key to use for cache.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Add FileState.hasMixin/hasMixinLibrary properties.

We will use them to decide which kind of key to use for cache.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/16833bce7cdf5086c83364016d01896f53ea6775
==========

[scheglov, 2017-06-12 19:43:39]

Committed patchset #2 (id:20001) manually as
16833bce7cdf5086c83364016d01896f53ea6775 (presubmit successful).