components/signin/ios/browser/oauth2_token_service_observer_bridge.h - Issue 2928383002: [ObjC ARC] Converts components/signin/ios/browser:browser to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/ios/browser/oauth2_token_service_observer_bridge.h

Issue 2928383002: [ObjC ARC] Converts components/signin/ios/browser:browser to ARC. (Closed)

Patch Set: Made other delegate explicitly weak. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/signin/ios/browser/merge_session_observer_bridge.h ('K') | « components/signin/ios/browser/merge_session_observer_bridge.mm ('k') | components/signin/ios/browser/oauth2_token_service_observer_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/ios/browser/oauth2_token_service_observer_bridge.h

diff --git a/components/signin/ios/browser/oauth2_token_service_observer_bridge.h b/components/signin/ios/browser/oauth2_token_service_observer_bridge.h

index 04d389623109b269126eb695ff75aac79e44304e..425a9b3e90e72381340b9c387b687b6adaeb7a65 100644

--- a/components/signin/ios/browser/oauth2_token_service_observer_bridge.h

+++ b/components/signin/ios/browser/oauth2_token_service_observer_bridge.h

@@ -7,6 +7,7 @@

#import <Foundation/Foundation.h>

+#import "base/ios/weak_nsobject.h"

#include "base/macros.h"

#include "google_apis/gaia/oauth2_token_service.h"

@@ -49,7 +50,7 @@ class OAuth2TokenServiceObserverBridge : public OAuth2TokenService::Observer {

private:

OAuth2TokenService* token_service_; // weak

- id<OAuth2TokenServiceObserverBridgeDelegate> delegate_;

+ base::WeakNSProtocol<id<OAuth2TokenServiceObserverBridgeDelegate>> delegate_;

msarda 2017/06/13 13:15:30 I do not know that much about ARC transition, so t

marq (ping after 24h) 2017/06/15 09:27:33 This header is included in non-arc targets, so it

DISALLOW_COPY_AND_ASSIGN(OAuth2TokenServiceObserverBridge);

};