[ObjC ARC] Converts components/signin/ios/browser:browser to ARC.

components/signin/ios/browser/account_consistency_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_IOS_BROWSER_ACCOUNT_CONSISTENCY_SERVICE_H_
 #define COMPONENTS_SIGNIN_IOS_BROWSER_ACCOUNT_CONSISTENCY_SERVICE_H_
 
 #include <deque>
 #include <map>
 #include <memory>
 #include <set>
 #include <string>
 
 #include "base/mac/scoped_nsobject.h"

[msarda, 2017/06/13 13:15:30]

Should this include be removed?

[marq (ping after 24h), 2017/06/15 09:27:33]

Done.

 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "components/content_settings/core/browser/cookie_settings.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #import "components/signin/ios/browser/manage_accounts_delegate.h"
 #include "ios/web/public/active_state_manager.h"
 
@@ skipping 146 matching lines @@
 
   // Whether a CHROME_CONNECTED cookie request is currently being applied.
   bool applying_cookie_requests_;
   // The queue of CHROME_CONNECTED cookie requests to be applied.
   std::deque<CookieRequest> cookie_requests_;
   // The map between domains where a CHROME_CONNECTED cookie is present and
   // the time when the cookie was last updated.
   std::map<std::string, base::Time> last_cookie_update_map_;
 
   // Web view used to apply the CHROME_CONNECTED cookie requests.
   base::scoped_nsobject<WKWebView> web_view_;

[msarda, 2017/06/13 13:15:30]

Should this change and be now a WKWebView*?

[marq (ping after 24h), 2017/06/15 09:27:33]

We can only do that in header files if the header isn't included in any non-ARC
targets. It looks like this one isn't used outside of this target, so it should
be OK to clean up that way.

   // Navigation delegate of |web_view_| that informs the service when a cookie
   // request has been applied.
-  base::scoped_nsobject<AccountConsistencyNavigationDelegate>
-      navigation_delegate_;
+  AccountConsistencyNavigationDelegate* navigation_delegate_;
 
   // Handlers reacting on GAIA responses with the X-Chrome-Manage-Accounts
   // header set.
   std::map<web::WebState*, std::unique_ptr<web::WebStatePolicyDecider>>
       web_state_handlers_;
 
   DISALLOW_COPY_AND_ASSIGN(AccountConsistencyService);
 };
 
 #endif  // COMPONENTS_SIGNIN_IOS_BROWSER_ACCOUNT_CONSISTENCY_SERVICE_H_