Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2928313002: Update AssistProcessor to use ChangeBuilder (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1112 lines, -1015 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 42 chunks +1063 lines, -997 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 5 chunks +38 lines, -17 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This has all of the same problems as the code in FixProcessor, but I wanted ...
3 years, 6 months ago (2017-06-11 16:12:06 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-11 20:10:43 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-12 14:28:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d824acbf719314a222db058bbe7a7ff281c01150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698