Deprecate native and extension notification delegates.

chrome/browser/notifications/notification_handler.h

Index: chrome/browser/notifications/notification_handler.h
diff --git a/chrome/browser/notifications/notification_handler.h b/chrome/browser/notifications/notification_handler.h
index 3e513963f1025b66135ae6788d2e0abb3345005f..ffe226de06d84dfb44f819a23af2fc901ce22907 100644
--- a/chrome/browser/notifications/notification_handler.h
+++ b/chrome/browser/notifications/notification_handler.h
@@ -21,6 +21,7 @@ class NotificationHandler {
  public:
   virtual ~NotificationHandler() {}
 
+  // Called after displaying a toast in case the caller needs some processing.
   virtual void OnShow(Profile* profile, const std::string& notification_id) = 0;
 
   // Process notification close events.
@@ -39,6 +40,12 @@ class NotificationHandler {
 
   // Open notification settings.
   virtual void OpenSettings(Profile* profile) = 0;
+
+  // Whether a notification should be displayed if in full screen. This is
+  // ignored by native notifications since the decision is made by the
+  // underlying OS in that case.
+  virtual bool ShouldDisplayOnFullScreen(Profile* profile,
+                                         const std::string& origin) const = 0;

[Peter Beverloo, 2017/06/13 22:56:41]

nit: drop `const`, I think we've learned our lesson about const correctness and
interfaces. Anita ran into another one today.

[Peter Beverloo, 2017/06/13 22:56:42]

Out of interest, why wouldn't we pass |origin| as a GURL or url::Origin?

[Miguel Garcia, 2017/06/14 09:39:38]

Done.

[Miguel Garcia, 2017/06/14 09:39:38]

I wanted to minimize the number of times string is converted to GURL and
viceversa just to go through all the layering.

 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_HANDLER_H_