Deprecate native and extension notification delegates.

chrome/browser/notifications/notification_common.h

Index: chrome/browser/notifications/notification_common.h
diff --git a/chrome/browser/notifications/notification_common.h b/chrome/browser/notifications/notification_common.h
index 9bf8d48a364e1c968c40b655abe8785ef19071d1..e625d4d9af89992d982fdceff73042a2003fed44 100644
--- a/chrome/browser/notifications/notification_common.h
+++ b/chrome/browser/notifications/notification_common.h
@@ -5,10 +5,22 @@
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_
 
+#include "base/feature_list.h"
+
+namespace features {
+
+// TODO(miguelg) We can probably get rid of this altogether.

[Peter Beverloo, 2017/06/13 22:56:41]

Yes. The extension one too.

[Miguel Garcia, 2017/06/14 09:39:38]

Acknowledged.

+extern const base::Feature kAllowFullscreenWebNotificationsFeature;
+
+}  // namespace features
+
 namespace content {
 class BrowserContext;
 }  // namespace content
 
+class Profile;
+class GURL;

[Peter Beverloo, 2017/06/13 22:56:40]

nit: alphabetize

[Miguel Garcia, 2017/06/14 09:39:38]

Done.

+
 // Shared functionality for both in page and persistent notification
 class NotificationCommon {
  public:
@@ -35,6 +47,8 @@ class NotificationCommon {
   // is updated.
   static void OpenNotificationSettings(
       content::BrowserContext* browser_context);
+
+  static bool ActiveTabIsFullScreen(Profile* profile, const GURL& origin);

[Peter Beverloo, 2017/06/13 22:56:41]

++docs. Maybe just call this ShouldDisplayOnFullScreen to match the handlers
too?

[Miguel Garcia, 2017/06/14 09:39:38]

Done.

 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_