Deprecate native and extension notification delegates.

chrome/browser/notifications/web_notification_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
 #define CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
 
 #include <string>
 
 #include "base/feature_list.h"
 #include "base/macros.h"
 #include "chrome/browser/notifications/notification_common.h"
 #include "chrome/browser/notifications/notification_delegate.h"
 #include "url/gurl.h"
 
 class Profile;
 
 namespace features {
 
 extern const base::Feature kAllowFullscreenWebNotificationsFeature;
 
 } // namespace features
 
 // Delegate class for Web Notifications.
 class WebNotificationDelegate : public NotificationDelegate {

[Peter Beverloo, 2017/06/13 22:56:42]

Eventually the Message Center display bridge will create this, right? The name
WebNotificationDelegate isn't really appropriate for extensions. Do you have
thoughts on what we might call it eventually?

[Miguel Garcia, 2017/06/14 09:39:38]

Yes, at this point the only reason why we cannot create it in the message center
directly is the delegate_id() method which requires another round of
refactoring. Almost there.

Agreed that WebNotificationDelegate is not great for extensions.
NotificationDelegate per se is also not good since there are other (non web and
non extension) notifications as well. Ideas welcome. They are essentially
DeveloperGeneratedNotifications but that sound pretty horrible :)

  public:
   WebNotificationDelegate(NotificationCommon::Type notification_type,
                           Profile* profile,
                           const std::string& notification_id,
                           const GURL& origin);
 
   // NotificationDelegate implementation.
   std::string id() const override;
   bool SettingsClick() override;
   bool ShouldDisplaySettingsButton() override;
   bool ShouldDisplayOverFullscreen() const override;
-  void Display() override;
   void Close(bool by_user) override;
   void Click() override;
   void ButtonClick(int button_index) override;
   void ButtonClickWithReply(int button_index,
                             const base::string16& reply) override;
 
  protected:
   ~WebNotificationDelegate() override;
   const GURL& origin() { return origin_; }
 
  private:
   NotificationCommon::Type notification_type_;
   Profile* profile_;
   std::string notification_id_;
   GURL origin_;
 
   DISALLOW_COPY_AND_ASSIGN(WebNotificationDelegate);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_