Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2239)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
index 6e1ad1f68c2f50dc08a9e83d90314a22f1124b64..69f5328ae949047563afdb55cdc58a79fc198f7a 100644
--- a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
+++ b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
@@ -131,6 +131,18 @@ cr.define('offlineInternals', function() {
* @return {!Promise} A promise firing when the task has been cancelled.
*/
cancelNwake: function() {},
+
+ /**
+ * Sends a request to generate page bundle.
+ * @return {!Promise} A promise firing when the request is sent.
dpapad 2017/06/12 23:29:20 Can you document the returned data structure? Prom
jianli 2017/06/12 23:48:15 Done.
+ */
+ generatePageBundle: function() {},
+
+ /**
+ * Sends a request to get operation.
+ * @return {!Promise} A promise firing when the request is sent.
dpapad 2017/06/12 23:29:20 Same here.
jianli 2017/06/12 23:48:15 Done.
+ */
+ getOperation: function() {},
};
/**
@@ -205,6 +217,16 @@ cr.define('offlineInternals', function() {
cancelNwake: function() {
return cr.sendWithPromise('cancelNwake');
},
+
+ /** @override */
+ generatePageBundle: function(data) {
+ return cr.sendWithPromise('generatePageBundle', data);
+ },
+
+ /** @override */
+ getOperation: function(data) {
+ return cr.sendWithPromise('getOperation', data);
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698