 Chromium Code Reviews
 Chromium Code Reviews Issue 2928243002:
  Return operation name in prefetch request callback and add internal page hookup  (Closed)
    
  
    Issue 2928243002:
  Return operation name in prefetch request callback and add internal page hookup  (Closed) 
  | Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h | 
| diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h | 
| index 2dba260b69eb840bace8fe76180435a5d99aba46..c68eeb6530ed20a5c08359366050d31542b4fb6c 100644 | 
| --- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h | 
| +++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h | 
| @@ -11,10 +11,13 @@ | 
| #include "components/offline_pages/core/background/save_page_request.h" | 
| #include "components/offline_pages/core/offline_page_model.h" | 
| #include "components/offline_pages/core/offline_store_types.h" | 
| +#include "components/offline_pages/core/prefetch/prefetch_types.h" | 
| #include "content/public/browser/web_ui_message_handler.h" | 
| namespace offline_pages { | 
| enum class GetRequestsResult; | 
| +class GeneratePageBundleRequest; | 
| +class GetOperationRequest; | 
| } | 
| namespace offline_internals { | 
| @@ -65,6 +68,12 @@ class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler { | 
| // Cancels an NWake signal. | 
| void HandleCancelNwake(const base::ListValue* args); | 
| + // Sends a request to genrate page bundle. | 
| 
dpapad
2017/06/12 23:29:20
The comment sounds a bit confusing. Does calling "
 | 
| + void HandleGeneratePageBundle(const base::ListValue* args); | 
| + | 
| + // Sends a request to get operation. | 
| + void HandleGetOperation(const base::ListValue* args); | 
| + | 
| // Callback for async GetAllPages calls. | 
| void HandleStoredPagesCallback( | 
| std::string callback_id, | 
| @@ -85,16 +94,18 @@ class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler { | 
| std::string callback_id, | 
| const offline_pages::MultipleItemStatuses& results); | 
| - // Turns a DeletePageResult enum into logical string. | 
| - std::string GetStringFromDeletePageResult( | 
| - offline_pages::DeletePageResult value); | 
| - | 
| - // Summarizes the MultipleItemStatuses vector with a string. | 
| - std::string GetStringFromDeleteRequestResults( | 
| - const offline_pages::MultipleItemStatuses& result); | 
| + // Callback for GeneratePageBundle/GetOperation request calls. | 
| + void HandlePrefetchRequestCallback( | 
| + std::string callback_id, | 
| + offline_pages::PrefetchRequestStatus status, | 
| + const std::string& operation_name, | 
| + const std::vector<offline_pages::RenderPageInfo>& pages); | 
| - // Turns a SavePageRequest::Status into logical string. | 
| - std::string GetStringFromSavePageStatus(); | 
| + // Callback for GetOperation calls. | 
| + void HandleGetOperationCallback( | 
| + std::string callback_id, | 
| + offline_pages::PrefetchRequestStatus status, | 
| + const std::vector<offline_pages::RenderPageInfo>& pages); | 
| // Offline page model to call methods on. | 
| offline_pages::OfflinePageModel* offline_page_model_; | 
| @@ -102,6 +113,10 @@ class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler { | 
| // Request coordinator for background offline actions. | 
| offline_pages::RequestCoordinator* request_coordinator_; | 
| + std::unique_ptr<offline_pages::GeneratePageBundleRequest> | 
| + generate_page_bundle_request_; | 
| + std::unique_ptr<offline_pages::GetOperationRequest> get_operation_request_; | 
| + | 
| // Factory for creating references in callbacks. | 
| base::WeakPtrFactory<OfflineInternalsUIMessageHandler> weak_ptr_factory_; |