Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: components/offline_pages/core/prefetch/generate_page_bundle_request.cc

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)
Patch Set: Fix comment indent in JS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/generate_page_bundle_request.cc
diff --git a/components/offline_pages/core/prefetch/generate_page_bundle_request.cc b/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
index 8fddcfba1b0dfd1ea0f4a0523e916cbb498452e1..94f9155b8ab592870b6bda79149dd1580090a40d 100644
--- a/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
+++ b/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
@@ -56,18 +56,19 @@ GeneratePageBundleRequest::~GeneratePageBundleRequest() {}
void GeneratePageBundleRequest::OnCompleted(PrefetchRequestStatus status,
const std::string& data) {
if (status != PrefetchRequestStatus::SUCCESS) {
- callback_.Run(status, std::vector<RenderPageInfo>());
+ callback_.Run(status, std::string(), std::vector<RenderPageInfo>());
return;
}
std::vector<RenderPageInfo> pages;
- if (!ParseOperationResponse(data, &pages)) {
+ std::string operation_name = ParseOperationResponse(data, &pages);
+ if (operation_name.empty()) {
callback_.Run(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF,
- std::vector<RenderPageInfo>());
+ std::string(), std::vector<RenderPageInfo>());
return;
}
- callback_.Run(PrefetchRequestStatus::SUCCESS, pages);
+ callback_.Run(PrefetchRequestStatus::SUCCESS, operation_name, pages);
}
} // offline_pages

Powered by Google App Engine
This is Rietveld 408576698