Return operation name in prefetch request callback and add internal page hookup

chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "components/offline_pages/core/background/request_coordinator.h"
 #include "components/offline_pages/core/background/save_page_request.h"
 #include "components/offline_pages/core/offline_page_model.h"
 #include "components/offline_pages/core/offline_store_types.h"
+#include "components/offline_pages/core/prefetch/prefetch_types.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace offline_pages {
 class PrefetchService;
 enum class GetRequestsResult;
+class GeneratePageBundleRequest;
+class GetOperationRequest;
 }
 
 namespace offline_internals {
 
 // Class acting as a controller of the chrome://offline-internals WebUI.
 class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler {
  public:
   OfflineInternalsUIMessageHandler();
   ~OfflineInternalsUIMessageHandler() override;
 
@@ skipping 33 matching lines @@
 
   // Load whether device is currently offline.
   void HandleGetNetworkStatus(const base::ListValue* args);
 
   // Schedules an NWake signal.
   void HandleScheduleNwake(const base::ListValue* args);
 
   // Cancels an NWake signal.
   void HandleCancelNwake(const base::ListValue* args);
 
+  // Sends a request to genrate page bundle.

[dpapad, 2017/06/12 23:29:20]

The comment sounds a bit confusing. Does calling "HandleGeneratePageBundle" send
a request, or handle a request that is sent from JS? Some question for
"HandleGetOperation" below.

[jianli, 2017/06/12 23:48:15]

This will trigger sending a network request and handling its response. Updated
the comment to make it better.

+  void HandleGeneratePageBundle(const base::ListValue* args);
+
+  // Sends a request to get operation.
+  void HandleGetOperation(const base::ListValue* args);
+
   // Callback for async GetAllPages calls.
   void HandleStoredPagesCallback(
       std::string callback_id,
       const offline_pages::MultipleOfflinePageItemResult& pages);
 
   // Callback for async GetRequests calls.
   void HandleRequestQueueCallback(
       std::string callback_id,
       offline_pages::GetRequestsResult result,
       std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests);
 
   // Callback for DeletePage/DeleteAllPages calls.
   void HandleDeletedPagesCallback(std::string callback_id,
                                   const offline_pages::DeletePageResult result);
 
   // Callback for DeleteRequest/DeleteAllRequests calls.
   void HandleDeletedRequestsCallback(
       std::string callback_id,
       const offline_pages::MultipleItemStatuses& results);
 
-  // Turns a DeletePageResult enum into logical string.
-  std::string GetStringFromDeletePageResult(
-      offline_pages::DeletePageResult value);
+  // Callback for GeneratePageBundle/GetOperation request calls.
+  void HandlePrefetchRequestCallback(
+      std::string callback_id,
+      offline_pages::PrefetchRequestStatus status,
+      const std::string& operation_name,
+      const std::vector<offline_pages::RenderPageInfo>& pages);
 
-  // Summarizes the MultipleItemStatuses vector with a string.
-  std::string GetStringFromDeleteRequestResults(
-      const offline_pages::MultipleItemStatuses& result);
-
-  // Turns a SavePageRequest::Status into logical string.
-  std::string GetStringFromSavePageStatus();
+  // Callback for GetOperation calls.
+  void HandleGetOperationCallback(
+      std::string callback_id,
+      offline_pages::PrefetchRequestStatus status,
+      const std::vector<offline_pages::RenderPageInfo>& pages);
 
   // Offline page model to call methods on.
   offline_pages::OfflinePageModel* offline_page_model_;
 
   // Request coordinator for background offline actions.
   offline_pages::RequestCoordinator* request_coordinator_;
 
   // Prefetch service for prefetching service logs and actions.
   offline_pages::PrefetchService* prefetch_service_;
 
+  std::unique_ptr<offline_pages::GeneratePageBundleRequest>
+      generate_page_bundle_request_;
+  std::unique_ptr<offline_pages::GetOperationRequest> get_operation_request_;
+
   // Factory for creating references in callbacks.
   base::WeakPtrFactory<OfflineInternalsUIMessageHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflineInternalsUIMessageHandler);
 };
 
 }  // namespace offline_internals
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_