Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)
Patch Set: Fix comment indent in JS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/prefetch/generate_page_bundle_request.h" 5 #include "components/offline_pages/core/prefetch/generate_page_bundle_request.h"
6 6
7 #include "base/test/mock_callback.h" 7 #include "base/test/mock_callback.h"
8 #include "components/offline_pages/core/prefetch/prefetch_request_test_base.h" 8 #include "components/offline_pages/core/prefetch/prefetch_request_test_base.h"
9 #include "components/offline_pages/core/prefetch/prefetch_types.h" 9 #include "components/offline_pages/core/prefetch/prefetch_types.h"
10 #include "components/offline_pages/core/prefetch/proto/offline_pages.pb.h" 10 #include "components/offline_pages/core/prefetch/proto/offline_pages.pb.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 EXPECT_EQ(kTestURL2, bundle_data.pages(1).url()); 70 EXPECT_EQ(kTestURL2, bundle_data.pages(1).url());
71 EXPECT_EQ(proto::NO_TRANSFORMATION, bundle_data.pages(1).transformation()); 71 EXPECT_EQ(proto::NO_TRANSFORMATION, bundle_data.pages(1).transformation());
72 } 72 }
73 73
74 TEST_F(GeneratePageBundleRequestTest, EmptyResponse) { 74 TEST_F(GeneratePageBundleRequestTest, EmptyResponse) {
75 base::MockCallback<PrefetchRequestFinishedCallback> callback; 75 base::MockCallback<PrefetchRequestFinishedCallback> callback;
76 std::unique_ptr<GeneratePageBundleRequest> request( 76 std::unique_ptr<GeneratePageBundleRequest> request(
77 CreateRequest(callback.Get())); 77 CreateRequest(callback.Get()));
78 78
79 PrefetchRequestStatus status; 79 PrefetchRequestStatus status;
80 std::string operation_name;
80 std::vector<RenderPageInfo> pages; 81 std::vector<RenderPageInfo> pages;
81 EXPECT_CALL(callback, Run(_, _)) 82 EXPECT_CALL(callback, Run(_, _, _))
82 .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&pages))); 83 .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&operation_name),
84 SaveArg<2>(&pages)));
83 RespondWithData(""); 85 RespondWithData("");
84 86
85 EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status); 87 EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status);
88 EXPECT_TRUE(operation_name.empty());
86 EXPECT_TRUE(pages.empty()); 89 EXPECT_TRUE(pages.empty());
87 } 90 }
88 91
89 TEST_F(GeneratePageBundleRequestTest, InvalidResponse) { 92 TEST_F(GeneratePageBundleRequestTest, InvalidResponse) {
90 base::MockCallback<PrefetchRequestFinishedCallback> callback; 93 base::MockCallback<PrefetchRequestFinishedCallback> callback;
91 std::unique_ptr<GeneratePageBundleRequest> request( 94 std::unique_ptr<GeneratePageBundleRequest> request(
92 CreateRequest(callback.Get())); 95 CreateRequest(callback.Get()));
93 96
94 PrefetchRequestStatus status; 97 PrefetchRequestStatus status;
98 std::string operation_name;
95 std::vector<RenderPageInfo> pages; 99 std::vector<RenderPageInfo> pages;
96 EXPECT_CALL(callback, Run(_, _)) 100 EXPECT_CALL(callback, Run(_, _, _))
97 .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&pages))); 101 .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&operation_name),
102 SaveArg<2>(&pages)));
98 RespondWithData("Some invalid data"); 103 RespondWithData("Some invalid data");
99 104
100 EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status); 105 EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status);
106 EXPECT_TRUE(operation_name.empty());
101 EXPECT_TRUE(pages.empty()); 107 EXPECT_TRUE(pages.empty());
102 } 108 }
103 109
104 } // namespace offline_pages 110 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698