chrome/browser/resources/offline_pages/offline_internals.html - Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup

Side by Side Diff: chrome/browser/resources/offline_pages/offline_internals.html

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/browser/resources/offline_pages/offline_internals.js » ('j') | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html lang="en" dir="ltr">	2 <html lang="en" dir="ltr">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Offline Internals</title>	5 <title>Offline Internals</title>

6 <meta name="viewport" content="width=device-width">	6 <meta name="viewport" content="width=device-width">

7 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	7 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

8 <link rel="stylesheet" href="offline_internals.css">	8 <link rel="stylesheet" href="offline_internals.css">

9	9

10 <link rel="import" href="chrome://resources/html/cr.html">	10 <link rel="import" href="chrome://resources/html/cr.html">

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 placeholder="http://www.url1.com, http://www.url2.com, ...">	78 placeholder="http://www.url1.com, http://www.url2.com, ...">

79 <button id="add-to-queue">Load in background</button>	79 <button id="add-to-queue">Load in background</button>

80 <div id="save-url-state"></div>	80 <div id="save-url-state"></div>

81	81

82 <h2>Prefetching</h2>	82 <h2>Prefetching</h2>

83 <div>	83 <div>

84 <div>	84 <div>

85 <button id="schedule-nwake">Schedule NWake</button>	85 <button id="schedule-nwake">Schedule NWake</button>

86 <button id="cancel-nwake">Cancel NWake</button>	86 <button id="cancel-nwake">Cancel NWake</button>

87 </div>	87 </div>

	88 <div>

	89 <div>

	90 <input id="request-data" type="text">
	dewittj 2017/06/12 18:31:04 There should be different input boxes for the two There should be different input boxes for the two types of operation, and at least a tiny bit of info about what to put here. GeneratePageBundle: "A list of URLs, separated by spaces" GetOperation: "An operation name returned by GeneratePageBundle" I'd also like to see more structured output for GeneratePageBundle, something readable on mobile. That can be left for a future change, but please add an Asana task or a bug for it. jianli 2017/06/12 22:40:30 Added 2nd input box. Added explanation for input b Show quoted text On 2017/06/12 18:31:04, dewittj wrote: > There should be different input boxes for the two types of operation, and at > least a tiny bit of info about what to put here. > > GeneratePageBundle: "A list of URLs, separated by spaces" > GetOperation: "An operation name returned by GeneratePageBundle" > > I'd also like to see more structured output for GeneratePageBundle, something > readable on mobile. That can be left for a future change, but please add an > Asana task or a bug for it. Added 2nd input box. Added explanation for input box values. Also made the output more structured.
	91 </div>

	92 <button id="generate-page-bundle">Generate Page Bundle</button>

	93 <button id="get-operation">Get Operation</button>

	94 </div>

88 </div>	95 </div>

	96 <div id="prefetch-actions-info"></div>
	dewittj 2017/06/12 18:31:04 This should probably have different formatting tha This should probably have different formatting that preserves whitespace. maybe style="white-space: pre-wrap"? jianli 2017/06/12 22:40:30 Done. Show quoted text On 2017/06/12 18:31:04, dewittj wrote: > This should probably have different formatting that preserves whitespace. maybe > style="white-space: pre-wrap"? Done.
89 </body>	97 </body>

90 </html>	98 </html>

OLD	NEW