Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: pkg/analyzer/lib/src/dart/ast/utilities.dart

Issue 2928173002: Copy type information for generic function types (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/ast/utilities.dart
diff --git a/pkg/analyzer/lib/src/dart/ast/utilities.dart b/pkg/analyzer/lib/src/dart/ast/utilities.dart
index eb1f70529063d516b53b1c2d63c76b8e3662c277..dc303a376d86f22bb5af790a49558326be638be6 100644
--- a/pkg/analyzer/lib/src/dart/ast/utilities.dart
+++ b/pkg/analyzer/lib/src/dart/ast/utilities.dart
@@ -5967,13 +5967,13 @@ class ResolutionCopier implements AstVisitor<bool> {
@override
bool visitGenericFunctionType(GenericFunctionType node) {
- GenericFunctionType toNode = this._toNode as GenericFunctionType;
+ GenericFunctionTypeImpl toNode = this._toNode as GenericFunctionTypeImpl;
if (_and(
_isEqualNodes(node.returnType, toNode.returnType),
_isEqualTokens(node.functionKeyword, toNode.functionKeyword),
_isEqualNodes(node.typeParameters, toNode.typeParameters),
_isEqualNodes(node.parameters, toNode.parameters))) {
- // TODO(brianwilkerson) Copy the type information.
+ toNode.type = node.type;
return true;
}
return false;
@@ -5981,7 +5981,7 @@ class ResolutionCopier implements AstVisitor<bool> {
@override
bool visitGenericTypeAlias(GenericTypeAlias node) {
- GenericTypeAlias toNode = this._toNode as GenericTypeAlias;
+ GenericTypeAliasImpl toNode = this._toNode as GenericTypeAliasImpl;
if (_and(
_isEqualNodes(node.documentationComment, toNode.documentationComment),
_isEqualNodeLists(node.metadata, toNode.metadata),
@@ -5991,7 +5991,6 @@ class ResolutionCopier implements AstVisitor<bool> {
_isEqualTokens(node.equals, toNode.equals),
_isEqualNodes(node.functionType, toNode.functionType),
_isEqualTokens(node.semicolon, toNode.semicolon))) {
- // TODO(brianwilkerson) Copy the type and element information.
return true;
}
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698