Return named output files if they're symlinks

client/run_isolated.py

Index: client/run_isolated.py
diff --git a/client/run_isolated.py b/client/run_isolated.py
index 00edf14f6ddd770e7def2a4c692638523dfed8ec..46a34e184ba3c569e37c6dd380074cb3fafb0d92 100755
--- a/client/run_isolated.py
+++ b/client/run_isolated.py
@@ -332,10 +332,13 @@ def link_outputs_to_outdir(run_dir, out_dir, outputs):
   isolateserver.create_directories(out_dir, outputs)
   for o in outputs:
     try:
-      file_path.link_file(
-          os.path.join(out_dir, o),
-          os.path.join(run_dir, o),
-          file_path.HARDLINK_WITH_FALLBACK)
+      infile = os.path.join(run_dir, o)
+      outfile = os.path.join(out_dir, o)
+      if os.path.islink(infile):

[M-A Ruel, 2017/06/09 17:00:40]

use fs.islink() otherwise this throws on Windows.

[aludwin, 2017/06/09 19:37:32]

Done.

+        # TODO(aludwin): handle directories
+        file_path.readable_copy(outfile, os.path.realpath(infile))

[M-A Ruel, 2017/06/09 17:00:40]

use fs.copy2()
I don't think realpath() is necessary.

[aludwin, 2017/06/09 19:37:32]

Done.

+      else:
+        file_path.link_file(outfile, infile, file_path.HARDLINK_WITH_FALLBACK)
     except OSError as e:
       logging.info("Couldn't collect output file %s: %s", o, e)