Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 292813008: Implement SetViewContents in the client lib (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Implement SetViewContents in the client lib. Updates the view manager sample app too.\ R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272389

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -6 lines) Patch
A + mojo/examples/sample_view_manager_app/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_win.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/DEPS View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 4 chunks +78 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-22 20:25:43 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-22 20:38:16 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-23 00:12:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/292813008/30001
6 years, 7 months ago (2014-05-23 00:14:05 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 01:20:12 UTC) #5
Message was sent while issue was closed.
Change committed as 272389

Powered by Google App Engine
This is Rietveld 408576698