Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/services/gcm/fake_gcm_client.cc

Issue 292813007: Remove dependency on content::BrowserThread from GCMDriver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use SequencedTaskRunner Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/fake_gcm_client.cc
diff --git a/chrome/browser/services/gcm/fake_gcm_client.cc b/chrome/browser/services/gcm/fake_gcm_client.cc
index b1f9ca3b7b5a8fa59418da758df046d7d318a8da..914dbee60a1c3119614f36c7d977df6a102cedc2 100644
--- a/chrome/browser/services/gcm/fake_gcm_client.cc
+++ b/chrome/browser/services/gcm/fake_gcm_client.cc
@@ -7,17 +7,22 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
+#include "base/sequenced_task_runner.h"
#include "base/sys_byteorder.h"
#include "base/time/time.h"
-#include "content/public/browser/browser_thread.h"
#include "google_apis/gcm/base/encryptor.h"
namespace gcm {
-FakeGCMClient::FakeGCMClient(StartMode start_mode)
+FakeGCMClient::FakeGCMClient(
+ StartMode start_mode,
+ const scoped_refptr<base::SequencedTaskRunner>& ui_thread,
+ const scoped_refptr<base::SequencedTaskRunner>& io_thread)
: delegate_(NULL),
status_(UNINITIALIZED),
start_mode_(start_mode),
+ ui_thread_(ui_thread),
+ io_thread_(io_thread),
weak_ptr_factory_(this) {
}
@@ -37,7 +42,7 @@ void FakeGCMClient::Initialize(
}
void FakeGCMClient::Start() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
DCHECK_NE(STARTED, status_);
if (start_mode_ == DELAY_START)
@@ -54,18 +59,18 @@ void FakeGCMClient::DoLoading() {
}
void FakeGCMClient::Stop() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
status_ = STOPPED;
}
void FakeGCMClient::CheckOut() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
status_ = CHECKED_OUT;
}
void FakeGCMClient::Register(const std::string& app_id,
const std::vector<std::string>& sender_ids) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
std::string registration_id = GetRegistrationIdFromSenderIds(sender_ids);
base::MessageLoop::current()->PostTask(
@@ -77,7 +82,7 @@ void FakeGCMClient::Register(const std::string& app_id,
}
void FakeGCMClient::Unregister(const std::string& app_id) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
base::MessageLoop::current()->PostTask(
FROM_HERE,
@@ -89,7 +94,7 @@ void FakeGCMClient::Unregister(const std::string& app_id) {
void FakeGCMClient::Send(const std::string& app_id,
const std::string& receiver_id,
const OutgoingMessage& message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(io_thread_->RunsTasksOnCurrentThread());
base::MessageLoop::current()->PostTask(
FROM_HERE,
@@ -110,20 +115,18 @@ GCMClient::GCMStatistics FakeGCMClient::GetStatistics() const {
}
void FakeGCMClient::PerformDelayedLoading() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK(ui_thread_->RunsTasksOnCurrentThread());
- content::BrowserThread::PostTask(
- content::BrowserThread::IO,
+ io_thread_->PostTask(
FROM_HERE,
base::Bind(&FakeGCMClient::DoLoading, weak_ptr_factory_.GetWeakPtr()));
}
void FakeGCMClient::ReceiveMessage(const std::string& app_id,
const IncomingMessage& message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK(ui_thread_->RunsTasksOnCurrentThread());
- content::BrowserThread::PostTask(
- content::BrowserThread::IO,
+ io_thread_->PostTask(
FROM_HERE,
base::Bind(&FakeGCMClient::MessageReceived,
weak_ptr_factory_.GetWeakPtr(),
@@ -132,10 +135,9 @@ void FakeGCMClient::ReceiveMessage(const std::string& app_id,
}
void FakeGCMClient::DeleteMessages(const std::string& app_id) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK(ui_thread_->RunsTasksOnCurrentThread());
- content::BrowserThread::PostTask(
- content::BrowserThread::IO,
+ io_thread_->PostTask(
FROM_HERE,
base::Bind(&FakeGCMClient::MessagesDeleted,
weak_ptr_factory_.GetWeakPtr(),

Powered by Google App Engine
This is Rietveld 408576698