Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: PRESUBMIT.py

Issue 2928103002: Disable the web presubmits (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The LUCI Authors. All rights reserved. 1 # Copyright 2015 The LUCI Authors. All rights reserved.
2 # Use of this source code is governed under the Apache License, Version 2.0 2 # Use of this source code is governed under the Apache License, Version 2.0
3 # that can be found in the LICENSE file. 3 # that can be found in the LICENSE file.
4 4
5 """Top-level presubmit script. 5 """Top-level presubmit script.
6 6
7 See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 def CommonChecks(input_api, output_api): 115 def CommonChecks(input_api, output_api):
116 results = [] 116 results = []
117 results.extend( 117 results.extend(
118 input_api.canned_checks.CheckChangeHasNoStrayWhitespace( 118 input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
119 input_api, output_api, 119 input_api, output_api,
120 source_file_filter=source_file_filter(input_api))) 120 source_file_filter=source_file_filter(input_api)))
121 results.extend( 121 results.extend(
122 input_api.canned_checks.CheckLicense( 122 input_api.canned_checks.CheckLicense(
123 input_api, output_api, header(input_api), 123 input_api, output_api, header(input_api),
124 source_file_filter=source_file_filter(input_api))) 124 source_file_filter=source_file_filter(input_api)))
125 results.extend(WebChecks(input_api, output_api)) 125 # TODO(dnj): re-enable when working, crbug/731519.
126 # results.extend(WebChecks(input_api, output_api))
126 return results 127 return results
127 128
128 129
129 def CheckChangeOnUpload(input_api, output_api): 130 def CheckChangeOnUpload(input_api, output_api):
130 results = CommonChecks(input_api, output_api) 131 results = CommonChecks(input_api, output_api)
131 results.extend(PreCommitGo(input_api, output_api, ['lint', 'pre-commit'])) 132 results.extend(PreCommitGo(input_api, output_api, ['lint', 'pre-commit']))
132 return results 133 return results
133 134
134 135
135 def CheckChangeOnCommit(input_api, output_api): 136 def CheckChangeOnCommit(input_api, output_api):
136 results = CommonChecks(input_api, output_api) 137 results = CommonChecks(input_api, output_api)
137 results.extend(input_api.canned_checks.CheckChangeHasDescription( 138 results.extend(input_api.canned_checks.CheckChangeHasDescription(
138 input_api, output_api)) 139 input_api, output_api))
139 results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription( 140 results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
140 input_api, output_api)) 141 input_api, output_api))
141 results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles( 142 results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
142 input_api, output_api)) 143 input_api, output_api))
143 results.extend(PreCommitGo( 144 results.extend(PreCommitGo(
144 input_api, output_api, ['continuous-integration'])) 145 input_api, output_api, ['continuous-integration']))
145 return results 146 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698