Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2928033005: Add type inference for assignment to local variables. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for assignment to local variables. Also fix some upwards inference cases for assignment to index expressions. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ef94f715a938d61740a500b390fb73e89558b897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+915 lines, -89 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 7 chunks +23 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 4 chunks +19 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 6 chunks +138 lines, -73 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart View 1 chunk +128 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart.direct.expect View 1 chunk +120 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart.outline.expect View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart.strong.expect View 1 chunk +120 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local.dart.direct.expect View 1 chunk +47 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local.dart.outline.expect View 1 chunk +30 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local.dart.strong.expect View 1 chunk +47 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart.direct.expect View 1 chunk +45 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart.outline.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart.strong.expect View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-09 21:32:06 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-09 21:52:06 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-09 22:13:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef94f715a938d61740a500b390fb73e89558b897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698