Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: content/shell/test_runner/text_input_controller.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/test_runner/test_runner_for_specific_view.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/test_runner/text_input_controller.cc
diff --git a/content/shell/test_runner/text_input_controller.cc b/content/shell/test_runner/text_input_controller.cc
index 672c7e41933da24d0548c0119a994a6dc9099e8d..9e7d7baad5e167005a87ca92067bd901a3c8bf88 100644
--- a/content/shell/test_runner/text_input_controller.cc
+++ b/content/shell/test_runner/text_input_controller.cc
@@ -322,6 +322,7 @@ void TextInputController::SetComposition(const std::string& text) {
}
void TextInputController::ForceTextInputStateUpdate() {
+ // TODO(lukasza): Finish adding OOPIF support to the layout tests harness.
CHECK(view()->MainFrame()->IsWebLocalFrame())
<< "WebView does not have a local main frame and"
" cannot handle input method controller tasks.";
@@ -338,6 +339,7 @@ TextInputController::GetInputMethodController() {
if (!view()->MainFrame())
return nullptr;
+ // TODO(lukasza): Finish adding OOPIF support to the layout tests harness.
CHECK(view()->MainFrame()->IsWebLocalFrame())
<< "WebView does not have a local main frame and"
" cannot handle input method controller tasks.";
« no previous file with comments | « content/shell/test_runner/test_runner_for_specific_view.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698