Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 893d84f30b0ab1569f50c664b8d93779c0df27b7..f04f695c49a9d9b5f356a12c66768274e5ae3128 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -612,7 +612,7 @@ bool HasPasswordField(const blink::WebLocalFrame& frame) {
// preceding the |password_element| either in a form, if it belongs to one, or
// in the |frame|.
blink::WebInputElement FindUsernameElementPrecedingPasswordElement(
- blink::WebFrame* frame,
+ blink::WebLocalFrame* frame,
const blink::WebInputElement& password_element) {
DCHECK(!password_element.IsNull());
@@ -763,7 +763,7 @@ void PasswordAutofillAgent::UpdateStateForTextChange(
&field_value_and_properties_map_);
}
- blink::WebFrame* const element_frame = element.GetDocument().GetFrame();
+ blink::WebLocalFrame* const element_frame = element.GetDocument().GetFrame();
// The element's frame might have been detached in the meantime (see
// http://crbug.com/585363, comments 5 and 6), in which case frame() will
// return null. This was hardly caused by form submission (unless the user
@@ -986,7 +986,8 @@ bool PasswordAutofillAgent::IsUsernameOrPasswordField(
// to be the username field.
std::unique_ptr<PasswordForm> password_form;
if (element.Form().IsNull()) {
- blink::WebFrame* const element_frame = element.GetDocument().GetFrame();
+ blink::WebLocalFrame* const element_frame =
+ element.GetDocument().GetFrame();
if (!element_frame)
return false;
@@ -1105,7 +1106,7 @@ void PasswordAutofillAgent::OnSameDocumentNavigationCompleted(
// Prompt to save only if the form is now gone, either invisible or
// removed from the DOM.
- blink::WebFrame* frame = render_frame()->GetWebFrame();
+ blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
const auto& password_form = provisionally_saved_form_.password_form();
// TODO(crbug.com/720347): This method could be called often and checking form
// visibility could be expesive. Add performance metrics for this.

Powered by Google App Engine
This is Rietveld 408576698