Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 71d53fc1416edf6440c4a9269d31446715384d09..2a32103546cebcf6521b342132ebac8cb76f4a70 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -4,6 +4,8 @@
#include "components/autofill/content/renderer/form_autofill_util.h"
+#include <algorithm>
+#include <limits>
#include <map>
#include <memory>
#include <set>
@@ -43,9 +45,9 @@ using blink::WebElement;
using blink::WebElementCollection;
using blink::WebFormControlElement;
using blink::WebFormElement;
-using blink::WebFrame;
using blink::WebInputElement;
using blink::WebLabelElement;
+using blink::WebLocalFrame;
using blink::WebNode;
using blink::WebOptionElement;
using blink::WebSelectElement;
@@ -1194,7 +1196,7 @@ bool ExtractFormData(const WebFormElement& form_element, FormData* data) {
data, NULL);
}
-bool IsFormVisible(blink::WebFrame* frame,
+bool IsFormVisible(blink::WebLocalFrame* frame,
const blink::WebFormElement& form_element,
const GURL& canonical_action,
const GURL& canonical_origin,
@@ -1473,7 +1475,7 @@ bool WebFormElementToFormData(
ExtractMask extract_mask,
FormData* form,
FormFieldData* field) {
- const WebFrame* frame = form_element.GetDocument().GetFrame();
+ const WebLocalFrame* frame = form_element.GetDocument().GetFrame();
if (!frame)
return false;
@@ -1762,7 +1764,7 @@ bool ClearPreviewedFormWithElement(const WebFormControlElement& element,
return true;
}
-bool IsWebpageEmpty(const blink::WebFrame* frame) {
+bool IsWebpageEmpty(const blink::WebLocalFrame* frame) {
blink::WebDocument document = frame->GetDocument();
return IsWebElementEmpty(document.Head()) &&
« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.h ('k') | components/autofill/content/renderer/form_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698