third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp - Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp b/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

index 009e19355c50c9b21953aca317a0f3a720cb5430..1c597485c84e12d70f071fb94b3416352206b18e 100644

--- a/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

+++ b/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

@@ -123,7 +123,7 @@ class BrowserControlsTest : public ::testing::Test {

Element* GetElementById(const WebString& id) {

return static_cast<Element*>(

- GetWebView()->MainFrame()->GetDocument().GetElementById(id));

+ GetWebView()->MainFrameImpl()->GetDocument().GetElementById(id));

}

WebViewBase* GetWebView() const { return helper_.WebView(); }