Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Rebasing... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index dd9335a1bc880877a4831721e1ceca956b42b5fd..5445f7fb4ef383ec97c147fbf2de77723eac9f57 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -16,12 +16,10 @@
#include "base/strings/utf_string_conversions.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
-#include "chrome/common/chrome_constants.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/render_messages.h"
#include "chrome/common/url_constants.h"
#include "chrome/renderer/prerender/prerender_helper.h"
-#include "chrome/renderer/web_apps.h"
#include "components/web_cache/renderer/web_cache_impl.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/renderer/content_renderer_client.h"
@@ -61,8 +59,6 @@ bool ChromeRenderViewObserver::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ChromeViewMsg_UpdateBrowserControlsState,
OnUpdateBrowserControlsState)
#endif
- IPC_MESSAGE_HANDLER(ChromeViewMsg_GetWebApplicationInfo,
- OnGetWebApplicationInfo)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SetWindowFeatures, OnSetWindowFeatures)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -86,50 +82,6 @@ void ChromeRenderViewObserver::OnUpdateBrowserControlsState(
}
#endif
-void ChromeRenderViewObserver::OnGetWebApplicationInfo() {
- WebFrame* main_frame = render_view()->GetWebView()->MainFrame();
- DCHECK(main_frame);
-
- WebApplicationInfo web_app_info;
- web_apps::ParseWebAppFromWebDocument(main_frame, &web_app_info);
-
- // The warning below is specific to mobile but it doesn't hurt to show it even
- // if the Chromium build is running on a desktop. It will get more exposition.
- // TODO(mlamouri): Associate this message with an actual frame, to avoid the
- // need to check whether or not the main frame is local.
- if (web_app_info.mobile_capable == WebApplicationInfo::MOBILE_CAPABLE_APPLE &&
- main_frame->IsWebLocalFrame()) {
- blink::WebConsoleMessage message(
- blink::WebConsoleMessage::kLevelWarning,
- "<meta name=\"apple-mobile-web-app-capable\" content=\"yes\"> is "
- "deprecated. Please include <meta name=\"mobile-web-app-capable\" "
- "content=\"yes\"> - "
- "http://developers.google.com/chrome/mobile/docs/installtohomescreen");
- main_frame->ToWebLocalFrame()->AddMessageToConsole(message);
- }
-
- // Prune out any data URLs in the set of icons. The browser process expects
- // any icon with a data URL to have originated from a favicon. We don't want
- // to decode arbitrary data URLs in the browser process. See
- // http://b/issue?id=1162972
- for (std::vector<WebApplicationInfo::IconInfo>::iterator it =
- web_app_info.icons.begin(); it != web_app_info.icons.end();) {
- if (it->url.SchemeIs(url::kDataScheme))
- it = web_app_info.icons.erase(it);
- else
- ++it;
- }
-
- // Truncate the strings we send to the browser process.
- web_app_info.title =
- web_app_info.title.substr(0, chrome::kMaxMetaTagAttributeLength);
- web_app_info.description =
- web_app_info.description.substr(0, chrome::kMaxMetaTagAttributeLength);
-
- Send(new ChromeViewHostMsg_DidGetWebApplicationInfo(
- routing_id(), web_app_info));
-}
-
void ChromeRenderViewObserver::OnSetWindowFeatures(
const blink::mojom::WindowFeatures& window_features) {
render_view()->GetWebView()->SetWindowFeatures(

Powered by Google App Engine
This is Rietveld 408576698