Chromium Code Reviews| Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc |
| diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc |
| index 4e1ef0bebc328bcec260c2b09dab9d8b99dad7b5..7a5090fd8d976f54d50a9292d88ccc2551ec0a7a 100644 |
| --- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc |
| +++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc |
| @@ -390,8 +390,9 @@ blink::WebDocument PhishingDOMFeatureExtractor::GetNextDocument() { |
| // Advance to the next frame that contains a document, with no wrapping. |
| if (frame) { |
| for (frame = frame->TraverseNext(); frame; frame = frame->TraverseNext()) { |
| - if (!frame->GetDocument().IsNull()) { |
| - return frame->GetDocument(); |
| + if (frame->IsWebLocalFrame() && |
| + !frame->ToWebLocalFrame()->GetDocument().IsNull()) { |
| + return frame->ToWebLocalFrame()->GetDocument(); |
|
Łukasz Anforowicz
2017/06/15 20:15:59
Skipping remote frames seems okay here?
dcheng
2017/06/15 23:17:00
Yeah. That being said, I'm quite skeptical of the
Łukasz Anforowicz
2017/06/16 19:39:24
Done.
|
| } |
| } |
| } else { |