Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/exported/WebRemoteFrameImpl.h" 5 #include "core/exported/WebRemoteFrameImpl.h"
6 6
7 #include "bindings/core/v8/WindowProxy.h" 7 #include "bindings/core/v8/WindowProxy.h"
8 #include "core/dom/Fullscreen.h" 8 #include "core/dom/Fullscreen.h"
9 #include "core/dom/RemoteSecurityContext.h" 9 #include "core/dom/RemoteSecurityContext.h"
10 #include "core/dom/SecurityContext.h" 10 #include "core/dom/SecurityContext.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 } 106 }
107 107
108 WebView* WebRemoteFrameImpl::View() const { 108 WebView* WebRemoteFrameImpl::View() const {
109 if (!GetFrame()) { 109 if (!GetFrame()) {
110 return nullptr; 110 return nullptr;
111 } 111 }
112 DCHECK(GetFrame()->GetPage()); 112 DCHECK(GetFrame()->GetPage());
113 return GetFrame()->GetPage()->GetChromeClient().GetWebView(); 113 return GetFrame()->GetPage()->GetChromeClient().GetWebView();
114 } 114 }
115 115
116 WebDocument WebRemoteFrameImpl::GetDocument() const {
117 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of
118 // code tries to access the document of a remote frame at the moment.
119 return WebDocument();
120 }
121
122 WebPerformance WebRemoteFrameImpl::Performance() const { 116 WebPerformance WebRemoteFrameImpl::Performance() const {
123 NOTREACHED(); 117 NOTREACHED();
124 return WebPerformance(); 118 return WebPerformance();
125 } 119 }
126 120
127 void WebRemoteFrameImpl::StopLoading() { 121 void WebRemoteFrameImpl::StopLoading() {
128 // TODO(dcheng,japhet): Calling this method should stop loads 122 // TODO(dcheng,japhet): Calling this method should stop loads
129 // in all subframes, both remote and local. 123 // in all subframes, both remote and local.
130 } 124 }
131 125
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 } 355 }
362 356
363 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, 357 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
364 WebRemoteFrameClient* client) 358 WebRemoteFrameClient* client)
365 : WebRemoteFrameBase(scope), 359 : WebRemoteFrameBase(scope),
366 frame_client_(RemoteFrameClientImpl::Create(this)), 360 frame_client_(RemoteFrameClientImpl::Create(this)),
367 client_(client), 361 client_(client),
368 self_keep_alive_(this) {} 362 self_keep_alive_(this) {}
369 363
370 } // namespace blink 364 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698