Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)
Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/exported/WebRemoteFrameImpl.h" 5 #include "core/exported/WebRemoteFrameImpl.h"
6 6
7 #include "bindings/core/v8/WindowProxy.h" 7 #include "bindings/core/v8/WindowProxy.h"
8 #include "core/dom/Fullscreen.h" 8 #include "core/dom/Fullscreen.h"
9 #include "core/dom/RemoteSecurityContext.h" 9 #include "core/dom/RemoteSecurityContext.h"
10 #include "core/dom/SecurityContext.h" 10 #include "core/dom/SecurityContext.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 } 115 }
116 116
117 WebView* WebRemoteFrameImpl::View() const { 117 WebView* WebRemoteFrameImpl::View() const {
118 if (!GetFrame()) { 118 if (!GetFrame()) {
119 return nullptr; 119 return nullptr;
120 } 120 }
121 DCHECK(GetFrame()->GetPage()); 121 DCHECK(GetFrame()->GetPage());
122 return GetFrame()->GetPage()->GetChromeClient().GetWebView(); 122 return GetFrame()->GetPage()->GetChromeClient().GetWebView();
123 } 123 }
124 124
125 WebDocument WebRemoteFrameImpl::GetDocument() const {
126 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of
127 // code tries to access the document of a remote frame at the moment.
128 return WebDocument();
129 }
130
131 WebPerformance WebRemoteFrameImpl::Performance() const { 125 WebPerformance WebRemoteFrameImpl::Performance() const {
132 NOTREACHED(); 126 NOTREACHED();
133 return WebPerformance(); 127 return WebPerformance();
134 } 128 }
135 129
136 void WebRemoteFrameImpl::StopLoading() { 130 void WebRemoteFrameImpl::StopLoading() {
137 // TODO(dcheng,japhet): Calling this method should stop loads 131 // TODO(dcheng,japhet): Calling this method should stop loads
138 // in all subframes, both remote and local. 132 // in all subframes, both remote and local.
139 } 133 }
140 134
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 } 364 }
371 365
372 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, 366 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
373 WebRemoteFrameClient* client) 367 WebRemoteFrameClient* client)
374 : WebRemoteFrameBase(scope), 368 : WebRemoteFrameBase(scope),
375 frame_client_(RemoteFrameClientImpl::Create(this)), 369 frame_client_(RemoteFrameClientImpl::Create(this)),
376 client_(client), 370 client_(client),
377 self_keep_alive_(this) {} 371 self_keep_alive_(this) {}
378 372
379 } // namespace blink 373 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698