Move GetDocument method from WebFrame to WebLocalFrame.

content/shell/renderer/layout_test/blink_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/layout_test/blink_test_runner.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <clocale>
 #include <cmath>
 #include <memory>
+#include <string>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/debugger.h"
 #include "base/files/file_path.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/md5.h"
@@ skipping 1016 matching lines @@
   test_runner::WebTestInterfaces* interfaces =
       LayoutTestRenderThreadObserver::GetInstance()->test_interfaces();
   if (!interfaces->TestIsRunning())
     return;
 
   TestFinished();
 }
 
 void BlinkTestRunner::OnTryLeakDetection() {
   blink::WebFrame* main_frame = render_view()->GetWebView()->MainFrame();
-  DCHECK_EQ(GURL(url::kAboutBlankURL), GURL(main_frame->GetDocument().Url()));
+  DCHECK_EQ(GURL(url::kAboutBlankURL),
+            url::Origin(main_frame->GetSecurityOrigin()).GetURL());

[dcheng, 2017/06/15 23:17:00]

I'm a little surprised this works -- wouldn't the origin be unique here
normally?

[Łukasz Anforowicz, 2017/06/16 19:39:24]

Oops - thanks for catching this.  I didn't catch this because I haven't run
third_party/WebKit/Tools/Scripts/run-webkit-tests with --enable-leak-detection
flag (and apparently CQ also doesn't do this).

I've rewritten the DCHECK to only trigger if the main frame is local.

   DCHECK(!main_frame->IsLoading());
 
   leak_detector_->TryLeakDetection(main_frame);

[Łukasz Anforowicz, 2017/06/16 19:39:24]

FWIW, the argument (i.e. |main_frame|) above is only ever used in
WebLeakDetectorImpl::PrepareForLeakDetection to stop the spellchecker if the
frame is local.

- I think this means that OnTryLeakDetection is applicable also in cases when
the main frame is remote.

- There might be something fishy about only stopping the spellchecker in the
main/local frame.  Hmmm...

[dcheng, 2017/06/20 09:02:21]

Yeah, seems odd. We probably need to go through and audit our various usage of
IsWebLocalFrame / ToWebLocalFrame at some point...

 }
 
 void BlinkTestRunner::OnReplyBluetoothManualChooserEvents(
     const std::vector<std::string>& events) {
   DCHECK(!get_bluetooth_events_callbacks_.empty());
   base::Callback<void(const std::vector<std::string>&)> callback =
       get_bluetooth_events_callbacks_.front();
   get_bluetooth_events_callbacks_.pop_front();
   callback.Run(events);
 }
 
 void BlinkTestRunner::ReportLeakDetectionResult(
     const LeakDetectionResult& report) {
   Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report));
 }
 
 void BlinkTestRunner::OnDestruct() {
   delete this;
 }
 
 }  // namespace content