Move GetDocument method from WebFrame to WebLocalFrame.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 764 matching lines @@
                 base::CommandLine::ForCurrentProcess()->HasSwitch(
                     switches::kEnableNaCl);
           } else if (is_pnacl_mime_type) {
             is_nacl_unrestricted = true;
           }
           GURL manifest_url;
           GURL app_url;
           if (is_nacl_mime_type || is_pnacl_mime_type) {
             // Normal NaCl/PNaCl embed. The app URL is the page URL.
             manifest_url = url;
-            app_url = frame->Top()->GetDocument().Url();
+            // TODO(lukasza, alexmos): https://crbug.com/728295: Don't assume
+            // that the top frame is local.
+            app_url = frame->Top()->ToWebLocalFrame()->GetDocument().Url();

[Łukasz Anforowicz, 2017/06/15 20:15:59]

This isn't worse than the current code, right?

[dcheng, 2017/06/15 23:17:00]

Doesn't seem worse =/

Didn't we have to "fix" this by passing around top document URL / origin for
plugins or something?

[Łukasz Anforowicz, 2017/06/16 19:39:24]

Ack.
I don't know.

- The issue with the code above has been "known" for a while. (e.g. see
https://crbug.com/466297#c11 from July 2016 which predates
https://crbug.com/728295 by a bit).

- I've tried to look at other callers of WebFrame::Top and I don't see anything
obviously applicable to the code above. 
ChromeContentRendererClient::OverrideCreatePlugin sends the top security origin
to the browser when asking for ChromeViewHostMsg_GetPluginInfo.  Simular
situation happens in ChromePluginPlaceholder::PluginListChanged and
RenderFrameImpl::CreatePlugin.

- Also note that |app_url|'s path gets later inspected by
AppCategorizer::IsHangoutsUrl.

           } else {
             // NaCl is being invoked as a content handler. Look up the NaCl
             // module using the MIME type. The app URL is the manifest URL.
             manifest_url = GetNaClContentHandlerURL(actual_mime_type, info);
             app_url = manifest_url;
           }
           const Extension* extension =
               extensions::RendererExtensionRegistry::Get()
                   ->GetExtensionOrAppByURL(manifest_url);
           if (!IsNaClAllowed(manifest_url,
@@ skipping 564 matching lines @@
   // it's allowed to access.
 #if BUILDFLAG(ENABLE_EXTENSIONS)
   return !IsStandaloneExtensionProcess();
 #else
   return true;
 #endif
 }
 
 std::unique_ptr<blink::WebContentSettingsClient>
 ChromeContentRendererClient::CreateWorkerContentSettingsClient(
-    content::RenderFrame* render_frame,
-    WebFrame* frame) {
-  return base::MakeUnique<WorkerContentSettingsClient>(render_frame, frame);
+    content::RenderFrame* render_frame) {
+  return base::MakeUnique<WorkerContentSettingsClient>(render_frame);
 }
 
 bool ChromeContentRendererClient::IsPluginAllowedToUseDevChannelAPIs() {
 #if BUILDFLAG(ENABLE_PLUGINS)
   // Allow access for tests.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePepperTesting)) {
     return true;
   }
 
@@ skipping 210 matching lines @@
 
   RecordYouTubeRewriteUMA(result);
   return corrected_url.ReplaceComponents(r);
 }
 
 std::unique_ptr<base::TaskScheduler::InitParams>
 ChromeContentRendererClient::GetTaskSchedulerInitParams() {
   return task_scheduler_util::
       GetRendererTaskSchedulerInitParamsFromCommandLine();
 }