Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 292803002: Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (Closed)

Created:
6 years, 7 months ago by asanka
Modified:
6 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (https://codereview.chromium.org/274193004/) Reason for revert: This patch was landed speculatively due to the suspicion that the removal of the ScopedAllowIO was to blame for http://crbug.com/372017. The cause of that issue was found to lie elsewhere. Original issue's description: > Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. > > BUG=61827 > NOTRY=true > NOTREECHECKS=true > R=asanka@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269405 TBR=mef@chromium.org BUG=61827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M net/base/filename_util_internal.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
asanka
Created Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.
6 years, 7 months ago (2014-05-19 17:17:58 UTC) #1
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 7 months ago (2014-05-19 17:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/292803002/1
6 years, 7 months ago (2014-05-19 17:19:37 UTC) #3
mef
lgtm
6 years, 7 months ago (2014-05-19 18:02:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 19:00:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 20:19:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28510)
6 years, 7 months ago (2014-05-19 20:19:25 UTC) #7
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 7 months ago (2014-05-19 20:58:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/292803002/1
6 years, 7 months ago (2014-05-19 20:59:40 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 22:18:56 UTC) #10
Message was sent while issue was closed.
Change committed as 271502

Powered by Google App Engine
This is Rietveld 408576698