Revert "Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also upda…

Revert "Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHANGELOG.md to announce its removal."

This reverts commit 4b6fa0d5fbd06fdca1db48c49fa31725ef629ac3.

BUG=
R=kevmoo@google.com

Committed: https://github.com/dart-lang/sdk/commit/033c18472d395c9ebb0cefd981cd867d758e66d8

[bkonyi, 2017-06-08 19:59:45]

bkonyi@google.com changed reviewers:
+ kevmoo@google.com, zra@google.com

[kevmoo, 2017-06-08 20:01:38]

We *could* do this.

Or just add in a `bool get alpnSupported => true` getter w/ @deprecated and
update the changelog...

[bkonyi, 2017-06-08 20:08:39]

On 2017/06/08 20:01:38, kevmoo wrote:
> We *could* do this.
> 
> Or just add in a `bool get alpnSupported => true` getter w/ @deprecated and
> update the changelog...

That would make the most sense actually. I'll go ahead and do that instead.

[bkonyi, 2017-06-08 20:39:28]

I've gone ahead and made your suggested change Kevin. I wasn't sure where the
@deprecated should be, so I placed it in the patch files and the security socket
declaration in the library folder. Let me know if this needs to be done a
different way.

[kevmoo, 2017-06-08 20:47:54]

lgtm

https://codereview.chromium.org/2928013002/diff/20001/sdk/lib/io/security_con...
File sdk/lib/io/security_context.dart (right):

https://codereview.chromium.org/2928013002/diff/20001/sdk/lib/io/security_con...
sdk/lib/io/security_context.dart:152: * Whether the platform supports ALPN.
It's good to put a note in the doccomment, too – explain that this always
returns `true` and that it will be removed in a future release.

[zra, 2017-06-08 20:50:24]

On 2017/06/08 20:39:28, bkonyi wrote:
> I've gone ahead and made your suggested change Kevin. I wasn't sure where the
> @deprecated should be, so I placed it in the patch files and the security
socket
> declaration in the library folder. Let me know if this needs to be done a
> different way.

I think @deprecated should only be needed in sdk/lib/io/security_context.dart
and we don't need it in the patch files.

[bkonyi, 2017-06-08 21:32:48]

Description was changed from

==========
Revert "Removed SecurityContext.alpnSupported, as ALPN is now supported on all
platforms. Also updated CHANGELOG.md to announce its removal."

This reverts commit 4b6fa0d5fbd06fdca1db48c49fa31725ef629ac3.

BUG=
==========

to

==========
Revert "Removed SecurityContext.alpnSupported, as ALPN is now supported on all
platforms. Also updated CHANGELOG.md to announce its removal."

This reverts commit 4b6fa0d5fbd06fdca1db48c49fa31725ef629ac3.

BUG=
R=kevmoo@google.com

Committed:
https://github.com/dart-lang/sdk/commit/033c18472d395c9ebb0cefd981cd867d758e66d8
==========

[bkonyi, 2017-06-08 21:32:49]

Committed patchset #3 (id:40001) manually as
033c18472d395c9ebb0cefd981cd867d758e66d8.