Issue 2928012: Rolled tango to @34.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2928012: Rolled tango to @34. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by akalin

Modified:
4 years ago

Reviewers:
ncarter, ghc

CC:
chromium-reviews

Visibility:
Public.

Description

Rolled tango to @34. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52521

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter

4 years, 10 months ago (2010-07-14 23:50:21 UTC) #2

Rubber stamp; please run it through the trybots.

On Wed, Jul 14, 2010 at 4:45 PM, <akalin@chromium.org> wrote:

> Reviewers: ncarter, ghc,
>
> Message:
> +ghc for review, +nick for rubber-stamp.
>
> Description:
> Rolled tango to @34.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/2928012/show
>
> Affected files:
>  M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
>
f6120c3924cacce06ea76e25c563612960ce58a4..8aa2edae79fac634fe11b343f0ee5dd4803718c2
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -46,7 +46,7 @@ deps = {
>     "http://protobuf.googlecode.com/svn/trunk@327",
>
>   "src/third_party/cacheinvalidation/files":
> -    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@33",
> +    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@34",
>
>   "src/tools/gyp":
>     "http://gyp.googlecode.com/svn/trunk@836",
>
>
>

Expand Messages | Collapse Messages