ui/gfx/font_fallback_win.cc - Issue 2927953003: Use CTFontCreateForString for RenderTextHarfbuzz on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_fallback_win.cc

Issue 2927953003: Use CTFontCreateForString for RenderTextHarfbuzz on Mac (Closed)

Patch Set: Keep last resort fallbacks Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/font_fallback_win.cc

diff --git a/ui/gfx/font_fallback_win.cc b/ui/gfx/font_fallback_win.cc

index 1610e27438350a55b6c43ccd5b604bd4910eb5ca..cf3c4172bf05c74cc21225008a997c1f93bdfa86 100644

--- a/ui/gfx/font_fallback_win.cc

+++ b/ui/gfx/font_fallback_win.cc

@@ -341,7 +341,7 @@ std::vector<Font> GetFallbackFonts(const Font& font) {

}

bool GetFallbackFont(const Font& font,

- const wchar_t* text,

+ const base::char16* text,

int text_length,

Font* result) {

// Creating a DirectWrite font fallback can be expensive. It's ok in the