Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2927933002: Add informal specification of asserts in initializer lists. (Closed)

Created:
3 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add informal specification of asserts in initializer lists. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/c4da9198c1e63ba8c346bf8e6c3082378f1c15eb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
A docs/language/informal/assert-in-initializer-list.md View 1 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 6 months ago (2017-06-08 11:19:09 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2927933002/diff/1/docs/language/informal/assert-in-initializer-list.md File docs/language/informal/assert-in-initializer-list.md (right): https://codereview.chromium.org/2927933002/diff/1/docs/language/informal/assert-in-initializer-list.md#newcode14 docs/language/informal/assert-in-initializer-list.md:14: The feature should now be implemented by all ...
3 years, 6 months ago (2017-06-08 11:44:59 UTC) #3
Lasse Reichstein Nielsen
3 years, 6 months ago (2017-06-08 11:45:49 UTC) #4
Lasse Reichstein Nielsen
3 years, 6 months ago (2017-06-08 11:46:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4da9198c1e63ba8c346bf8e6c3082378f1c15eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698