Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

Issue 2927823002: Drop ImageLoader in plugins (Closed)
Patch Set: Drop ImageLoader in plugins Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLEmbedElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 "Embed type changed"); 107 "Embed type changed");
108 } else { 108 } else {
109 RequestPluginCreationWithoutLayoutObjectIfPossible(); 109 RequestPluginCreationWithoutLayoutObjectIfPossible();
110 } 110 }
111 } else if (params.name == codeAttr) { 111 } else if (params.name == codeAttr) {
112 // TODO(schenney): Remove this branch? It's not in the spec and we're not in 112 // TODO(schenney): Remove this branch? It's not in the spec and we're not in
113 // the HTMLAppletElement hierarchy. 113 // the HTMLAppletElement hierarchy.
114 url_ = StripLeadingAndTrailingHTMLSpaces(params.new_value); 114 url_ = StripLeadingAndTrailingHTMLSpaces(params.new_value);
115 } else if (params.name == srcAttr) { 115 } else if (params.name == srcAttr) {
116 url_ = StripLeadingAndTrailingHTMLSpaces(params.new_value); 116 url_ = StripLeadingAndTrailingHTMLSpaces(params.new_value);
117 if (GetLayoutObject() && IsImageType()) { 117 if (GetLayoutObject()) {
118 if (!image_loader_)
119 image_loader_ = HTMLImageLoader::Create(this);
120 image_loader_->UpdateFromElement(ImageLoader::kUpdateIgnorePreviousError);
121 } else if (GetLayoutObject()) {
122 // Check if this Embed can transition from potentially-active to active 118 // Check if this Embed can transition from potentially-active to active
123 if (FastHasAttribute(typeAttr)) { 119 if (FastHasAttribute(typeAttr)) {
124 SetNeedsPluginUpdate(true); 120 SetNeedsPluginUpdate(true);
125 LazyReattachIfNeeded(); 121 LazyReattachIfNeeded();
126 } 122 }
127 } else { 123 } else {
128 RequestPluginCreationWithoutLayoutObjectIfPossible(); 124 RequestPluginCreationWithoutLayoutObjectIfPossible();
129 } 125 }
130 } else { 126 } else {
131 HTMLPlugInElement::ParseAttribute(params); 127 HTMLPlugInElement::ParseAttribute(params);
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 for (HTMLObjectElement* object = 222 for (HTMLObjectElement* object =
227 Traversal<HTMLObjectElement>::FirstAncestor(*this); 223 Traversal<HTMLObjectElement>::FirstAncestor(*this);
228 object; object = Traversal<HTMLObjectElement>::FirstAncestor(*object)) { 224 object; object = Traversal<HTMLObjectElement>::FirstAncestor(*object)) {
229 if (object->IsExposed()) 225 if (object->IsExposed())
230 return false; 226 return false;
231 } 227 }
232 return true; 228 return true;
233 } 229 }
234 230
235 } // namespace blink 231 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLEmbedElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698