Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: src/builtins/s390/builtins-s390.cc

Issue 2927813004: PPC/s390: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/s390/builtins-s390.cc
diff --git a/src/builtins/s390/builtins-s390.cc b/src/builtins/s390/builtins-s390.cc
index a3fd0a42cdbb723578815c67bc9639ff0bf1868d..84b90b68f06a142566336ee64f7ba475acd604a5 100644
--- a/src/builtins/s390/builtins-s390.cc
+++ b/src/builtins/s390/builtins-s390.cc
@@ -1078,20 +1078,16 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
// Get the bytecode array from the function object (or from the DebugInfo if
// it is present) and load it into kInterpreterBytecodeArrayRegister.
+ Label maybe_load_debug_bytecode_array, bytecode_array_loaded;
__ LoadP(r2, FieldMemOperand(r3, JSFunction::kSharedFunctionInfoOffset));
- Label array_done;
- Register debug_info = r4;
- DCHECK(!debug_info.is(r2));
- __ LoadP(debug_info,
- FieldMemOperand(r2, SharedFunctionInfo::kDebugInfoOffset));
// Load original bytecode array or the debug copy.
__ LoadP(kInterpreterBytecodeArrayRegister,
FieldMemOperand(r2, SharedFunctionInfo::kFunctionDataOffset));
- __ TestIfSmi(debug_info);
- __ beq(&array_done);
- __ LoadP(kInterpreterBytecodeArrayRegister,
- FieldMemOperand(debug_info, DebugInfo::kDebugBytecodeArrayOffset));
- __ bind(&array_done);
+ __ LoadP(r4, FieldMemOperand(r2, SharedFunctionInfo::kDebugInfoOffset));
+
+ __ TestIfSmi(r4);
+ __ bne(&maybe_load_debug_bytecode_array);
+ __ bind(&bytecode_array_loaded);
// Check whether we should continue to use the interpreter.
// TODO(rmcilroy) Remove self healing once liveedit only has to deal with
@@ -1184,6 +1180,20 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
LeaveInterpreterFrame(masm, r4);
__ Ret();
+ // Load debug copy of the bytecode array if it exists.
+ // kInterpreterBytecodeArrayRegister is already loaded with
+ // SharedFunctionInfo::kFunctionDataOffset.
+ Label done;
+ __ bind(&maybe_load_debug_bytecode_array);
+ __ LoadP(ip, FieldMemOperand(r4, DebugInfo::kFlagsOffset));
+ __ SmiUntag(ip);
+ __ tmll(ip, Operand(DebugInfo::kHasBreakInfo));
+ __ beq(&done);
+ __ LoadP(kInterpreterBytecodeArrayRegister,
+ FieldMemOperand(r4, DebugInfo::kDebugBytecodeArrayOffset));
+ __ bind(&done);
+ __ b(&bytecode_array_loaded);
+
// If the shared code is no longer this entry trampoline, then the underlying
// function has been switched to a different kind of code and we heal the
// closure by switching the code entry field over to the new code as well.
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698